1228158 - Add support for setting alert summary status and linking to bugs

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

For performance sheriffing, we need to be able to link performance alert summaries to bugs as well as set their status to different values (e.g. investigating or wontfix). This bug will track the implementation of a first draft of this functionality.

Comment 2

[William Lachance (:wlach)]

(repasting from dupe bug)

Based on conversations we've had earlier, I'd like to start with the following possibilities:

Untriaged
Won't fix
Resolved
Backed out
Invalid
Investigating
Duplicate

We may need to change this later, but this seems like a good working set to start with. For simplicity, I'm going to add the ability to set (or unset) an alert summary's status to "invalid" (for the case that perfherder generates invalid alerts).

Comment 3

[William Lachance (:wlach)]

Attachment: PR

This is pretty limited: it just allows you to set an alert as "invalid" if its status is "untriaged". If it's "invalid", you can set it back to "untriaged".

Other stuff will be built on this. :)

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8699221 [details] [review]
PR

On further thought/discussion, I'm not sure if the alert summary level is the right place to set status. I think it might be preferable to do that on the level of the individual alert. Going to try reworking things that way, cancelling for now.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8699221 [details] [review]
PR

Ok, here's an updated PR which lets you set bug #'s, invalid status, etc. on a per-alert level. I think it works pretty well for a first draft.

Obviously this needs refinement but I'd rather get something basic done and play around with it. Let me know what you think!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8699221 [details] [review]
PR

a few questions and I would like to have additional bugs on file with appropriate comments in the code to handle bug filing and other modifications to the alerts (outside of summary and bug).

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f47197ddd9c85a0738a59661b60000e33e904e01
Bug 1228158 - Add ability to set alert status and bug # (server side)

https://github.com/mozilla/treeherder/commit/2acef3304199fe424c6f3b2585989c5f5fb83232
Bug 1228158 - Display + add ability to set alert status (client)

Comment 8

[William Lachance (:wlach)]

Filed bug 1234320 as a followup for the bug filing.