Closed
Bug 1228281
Opened 9 years ago
Closed 9 years ago
[GTK3] add padding to buttons
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: stransky, Unassigned)
References
Details
Attachments
(2 files)
|
2.02 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
|
2.02 KB,
patch
|
Details | Diff | Splinter Review |
entry and comboboxes have padding now but buttons are extra slim. So let's add padding there too and compensate extra border from forms.css (http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css#686)
|
Reporter | |
Comment 1•9 years ago
|
||
That's similar what we have for GtkEntry.
Attachment #8692470 -
Flags: review?(karlt)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8692470 [details] [diff] [review]
patch
>+ // XXX: Subtract 1 pixel from the border to account for the default
>+ // border in forms.css. See bug 1228281.
Instead of "default border" say "added -moz-focus-inner border" because
nsITheme::GetWidgetBorder() usually overrides element borders, but this is
special.
https://hg.mozilla.org/mozilla-central/annotate/7883e81f3c305078353ca27a6b1adb8c769d5904/layout/forms/nsButtonFrameRenderer.cpp#l439
http://hg.mozilla.org/mozilla-central/annotate/74c7941a9e22/layout/style/forms.css#l686
Attachment #8692470 -
Flags: review?(karlt) → review+
|
|
Reporter | |
Comment 3•9 years ago
|
||
Thanks, there's a patch for check-in. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4df4cdb9f3f0
|
|
Reporter | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•