Closed Bug 1228281 Opened 9 years ago Closed 8 years ago

[GTK3] add padding to buttons

Categories

(Core :: Widget: Gtk, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: stransky, Unassigned)

References

Details

Attachments

(2 files)

entry and comboboxes have padding now but buttons are extra slim. So let's add padding there too and compensate extra border from forms.css (http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css#686)
Attached patch patchSplinter Review
That's similar what we have for GtkEntry.
Attachment #8692470 - Flags: review?(karlt)
Comment on attachment 8692470 [details] [diff] [review]
patch

>+            // XXX: Subtract 1 pixel from the border to account for the default
>+            // border in forms.css. See bug 1228281.

Instead of "default border" say "added -moz-focus-inner border" because
nsITheme::GetWidgetBorder() usually overrides element borders, but this is
special.

https://hg.mozilla.org/mozilla-central/annotate/7883e81f3c305078353ca27a6b1adb8c769d5904/layout/forms/nsButtonFrameRenderer.cpp#l439
http://hg.mozilla.org/mozilla-central/annotate/74c7941a9e22/layout/style/forms.css#l686
Attachment #8692470 - Flags: review?(karlt) → review+
https://hg.mozilla.org/mozilla-central/rev/3ae71e279abd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Depends on: 1269108
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: