1228303 - Fix jshint errors

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Michiel de Jong [:michielbdejong]]

tests/python/gaia-ui-tests/gaiatest/atoms/remote_date.js: line 3, col 3, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/remote_date.js: line 3, col 24, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/remote_date.js: line 12, col 4, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/remote_date.js: line 14, col 26, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 2, col 3, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 3, col 50, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 4, col 32, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 5, col 34, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 9, col 40, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 13, col 41, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 18, col 47, Missing "use strict" statement. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 20, col 26, Missing "use strict" statement. (ERROR)

Comment 1

[Michiel de Jong [:michielbdejong]]

It seems these files are copied at some point (during `make test-integration`?) from tests/atoms/

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1228303-fix-jshint-errors > mozilla-b2g:master

Comment 3

[Michiel de Jong [:michielbdejong]]

I got that output when running `make hint` locally, and found that tests/python/gaia-ui-tests/gaiatest/atoms/ was a folder excluded by tests/python/gaia-ui-tests/gaiatest/.gitignore, but created by root at some point.

Comment 4

[Johan Lorenzo [:jlorenzo]]

tests/python/gaia-ui-tests/gaiatest/atoms/ is a simple copy of tests/atoms. This folder is created when you run tests/python/gaia-ui-tests/gaiatest/setup.py[1].

I wonder why this issues shows locally, whereas it doesn't on treeherder[2]

[1] https://github.com/mozilla-b2g/gaia/blob/46dc0aa9c4cf3d2beef0f18f7fcbb96c8dc5ba09/tests/python/gaia-ui-tests/setup.py#L20
[2] https://treeherder.mozilla.org/#/jobs?repo=gaia&filter-job_type_symbol=JSHint&fromchange=86b2faa37afe

Comment 5

[Michiel de Jong [:michielbdejong]]

Right, to reproduce the problem (in master) and the solution (on this branch), run:

> cd tests/python/gaia-ui-tests ; rm -r gaiatest/atoms ; python setup.py ; cd ../../.. ; make hint

However, this solution introduces new `make hint` errors:
Running jshint...
tests/python/gaia-ui-tests/gaiatest/atoms/remote_date.js: line 16, col 9, Possible strict violation. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/remote_date.js: line 16, col 15, Strict violation. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 22, col 9, Possible strict violation. (ERROR)
tests/python/gaia-ui-tests/gaiatest/atoms/screenshot.js: line 22, col 15, Strict violation. (ERROR)

I guess that was the reasons those files don't have `'use strict';`? Not sure how to resolve these new errors.

Comment 6

[Martijn Wargers (dead)]

I don't think those 2 files are used at all, so you might as well just remove them.

Comment 7

[BMO Automation]

Firefox OS is not being worked on