1228339 - [Static Analysis][Uninitialized Members In Class] Class MmapWrapper from LulElf.cpp has some uninitialized memebers

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that class MmapWrapper has memebers: base and size_ uninitialized.

Comment 1

[Andi [:andi]]

Attachment: Bug 1228339.diff

Hello David,

Could you please take a look other this small patch and tell me if everything is ok? It's not much, there are only 2 inits in the constructor.

THX

Comment 2

[Julian Seward [:jseward]]

Comment on attachment 8692532 [details] [diff] [review]
Bug 1228339.diff

Review of attachment 8692532 [details] [diff] [review]:
-----------------------------------------------------------------

Is not strictly necessary.  But if it keeps CV happy, I'm fine with it.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d6721e243d3

Comment 4

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb2f99b42d57881879554d9badc1680e2774ddcb
Backed out changeset 0d6721e243d3 (bug 1228339) for build bustage

Comment 5

[Gian-Carlo Pascutto [:gcp]]

The actual error was:

/home/worker/workspace/gecko/tools/profiler/lul/LulElf.cpp:145:10: error: '{anonymous}::MmapWrapper::size_' will be initialized after [-Werror=reorder]
/home/worker/workspace/gecko/tools/profiler/lul/LulElf.cpp:144:9: error:   'void* {anonymous}::MmapWrapper::base_' [-Werror=reorder]
/home/worker/workspace/gecko/tools/profiler/lul/LulElf.cpp:123:3: error:   when initialized here [-Werror=reorder]

Comment 6

[Andi [:andi]]

Attachment: Bug 1228339.diff

I've fixed the issue, can you please check-in?

Comment 7

[Gian-Carlo Pascutto [:gcp]]

While you're at it, can you check your hg settings? The patch is missing an author. If you look at the commit in m-i, the author was garbled there too: Bogdan Postelnicu <bogdan.postelnicu>

You probably want a username= in your .hgrc, as well as set the qnew defaults to -Ue. See our docs: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 8

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41b40ca1e905

Comment 9

[Andi [:andi]]

Thank you, is the patch ok?

Comment 10

[Gian-Carlo Pascutto [:gcp]]

It's running on try now, we'll see. (The author info is missing but whoever checks it in might be able to fix that on the go)

Comment 11

[Andi [:andi]]

Thank you for the info it's strange that the author is missing maybe because i'm using TortoiseHG

Comment 12

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/984115c3af750b37c549642760c7802d8f531a08
Bug 1228339 - Initialize members in class. r=jseward

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/984115c3af75