1228342 - [Static Analysis][Uninitialized Members In Class] Class LoadInfo from LoadInfo.cpp has member mTainting uninitialized in one constructor

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that mTainting is uninitialized in one contructor:
LoadInfo::LoadInfo(nsIPrincipal* aLoadingPrincipal,
                   nsIPrincipal* aTriggeringPrincipal,
                   nsSecurityFlags aSecurityFlags,
                   nsContentPolicyType aContentPolicyType,
                   bool aUpgradeInsecureRequests,
                   bool aUpgradeInsecurePreloads,
                   uint64_t aInnerWindowID,
                   uint64_t aOuterWindowID,
                   uint64_t aParentOuterWindowID,
                   bool aEnforceSecurity,
                   bool aInitialSecurityCheckDone,
                   const OriginAttributes& aOriginAttributes,
                   nsTArray<nsCOMPtr<nsIPrincipal>>& aRedirectChainIncludingInternalRedirects,
                   nsTArray<nsCOMPtr<nsIPrincipal>>& aRedirectChain)

Comment 1

[Andi [:andi]]

Attachment: Bug 1228342.diff

Hello Patrick,

Could you please take a look over this patch?

THX

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8692543 [details] [diff] [review]
Bug 1228342.diff

lgtm, but let's double check with Ben that its the right default

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8692543 [details] [diff] [review]
Bug 1228342.diff

Review of attachment 8692543 [details] [diff] [review]:
-----------------------------------------------------------------

Wow.  Thanks for catching this!

Comment 4

[Carsten Book [:Tomcat]]

Hi, this failed to apply:

patching file netwerk/base/LoadInfo.cpp
Hunk #1 FAILED at 127
1 out of 1 hunks FAILED -- saving rejects to file netwerk/base/LoadInfo.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh Bug_1228342.diff

could you take a look, thanks!

Comment 5

[Andi [:andi]]

Attachment: Bug 1228342.diff

I've updated the patch, it seemed that were several updates to LoadInfo.cpp from the time i've made the patch till now when it was tried to apply it. Updated to the last version and i've qrefresh it.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b77be698443

Comment 7

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e887a5f28f6c8ff8c0eb00eeaf11ec50ba1a4b3
Backed out changeset 7b77be698443 (bug 1228342) for build bustage ON CLOSED TREE

Comment 8

[Andi [:andi]]

Attachment: Bug 1228342.diff

this one should do it.
THX

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b6075887a72

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9b6075887a72