Closed Bug 1228342 Opened 6 years ago Closed 5 years ago
[Static Analysis][Uninitialized Members In Class] Class Load
Info from Load Info .cpp has member m Tainting uninitialized in one constructor
The Static Analysis tool Coverity added that mTainting is uninitialized in one contructor: LoadInfo::LoadInfo(nsIPrincipal* aLoadingPrincipal, nsIPrincipal* aTriggeringPrincipal, nsSecurityFlags aSecurityFlags, nsContentPolicyType aContentPolicyType, bool aUpgradeInsecureRequests, bool aUpgradeInsecurePreloads, uint64_t aInnerWindowID, uint64_t aOuterWindowID, uint64_t aParentOuterWindowID, bool aEnforceSecurity, bool aInitialSecurityCheckDone, const OriginAttributes& aOriginAttributes, nsTArray<nsCOMPtr<nsIPrincipal>>& aRedirectChainIncludingInternalRedirects, nsTArray<nsCOMPtr<nsIPrincipal>>& aRedirectChain)
Hello Patrick, Could you please take a look over this patch? THX
Comment on attachment 8692543 [details] [diff] [review] Bug 1228342.diff lgtm, but let's double check with Ben that its the right default
Comment on attachment 8692543 [details] [diff] [review] Bug 1228342.diff Review of attachment 8692543 [details] [diff] [review]: ----------------------------------------------------------------- Wow. Thanks for catching this!
Attachment #8692543 - Flags: review?(bkelly) → review+
Hi, this failed to apply: patching file netwerk/base/LoadInfo.cpp Hunk #1 FAILED at 127 1 out of 1 hunks FAILED -- saving rejects to file netwerk/base/LoadInfo.cpp.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh Bug_1228342.diff could you take a look, thanks!
I've updated the patch, it seemed that were several updates to LoadInfo.cpp from the time i've made the patch till now when it was tried to apply it. Updated to the last version and i've qrefresh it.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e887a5f28f6c8ff8c0eb00eeaf11ec50ba1a4b3 Backed out changeset 7b77be698443 (bug 1228342) for build bustage ON CLOSED TREE
this one should do it. THX
You need to log in before you can comment on or make changes to this bug.