Closed
Bug 1228348
Opened 10 years ago
Closed 10 years ago
Allow l20n-service to run in a worker context
Categories
(Firefox OS Graveyard :: Gaia::L10n, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
We should make it possible to run l20n-service in a worker context, i.e. without referencing window and document.
We'll need to move the code which is responsible for querying <head> to get the list of the available languages to the client. Similarly, we'll need to listen to window's languagechange and document's additionallanguageschange on the client, too.
This could be an opportunity to make contexts immutable, i.e. permanently bound to a given list of negotiated languages.
|
Assignee | |
Comment 1•10 years ago
|
||
I need to do some more testing on the device especially regarding the getAdditionalLanguages API to make sure everything works as expected, but I think this is ready for your review, Zibi.
The performance is promising:
music.gaiamobile.org base: mean 1: mean 1: delta 1: p-value
--------------------- ---------- ------- -------- ----------
navigationLoaded 309 310 0 0.96
navigationInteractive 324 324 -0 0.97
visuallyLoaded 718 640 -78 * 0.00
contentInteractive 718 640 -78 * 0.00
fullyLoaded 958 932 -26 * 0.00
uss 15.659 15.520 -0.139 * 0.00
pss 20.126 19.995 -0.131 * 0.00
rss 35.332 35.209 -0.123 * 0.00
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8696711 [details] [review]
Pull request
Cool!
Can you verify no SMS perf regression before landing?
Attachment #8696711 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Can you verify no SMS perf regression before landing?
Raptor results for SMS look good as well:
sms.gaiamobile.org base: mean 1: mean 1: delta 1: p-value
--------------------- ---------- ------- -------- ----------
visuallyLoaded 622 627 5 0.80
contentInteractive 983 965 -18 0.45
objectsInitEnd 991 972 -18 0.44
fullyLoaded 1809 1778 -32 0.17
uss 20.212 19.773 -0.439 * 0.01
rss 40.706 40.163 -0.543 * 0.00
pss 25.081 24.616 -0.465 * 0.01
navigationLoaded 424 419 -5 0.46
willRenderThreads 449 443 -6 0.34
navigationInteractive 451 445 -6 0.32
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•