Experiment add-ons can no more use a chrome.manifest

RESOLVED FIXED in Firefox 43, Firefox OS v2.5

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mak, Assigned: mossop)

Tracking

({regression})

Trunk
mozilla45
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 unaffected, firefox43+ fixed, firefox44+ fixed, firefox45 fixed, b2g-v2.5 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
experiments should ideally work like bootstrapped add-ons, differences may really hurt productivity (I spent time today trying to figure why my manifest was being ignored)
(Reporter)

Comment 1

2 years ago
[Tracking Requested - why for this release]: There may be experiments hitting this in the wild, and I'm working on a new one.
status-firefox42: --- → unaffected
status-firefox43: --- → affected
status-firefox44: --- → affected
tracking-firefox43: --- → ?
tracking-firefox44: --- → ?
(Reporter)

Updated

2 years ago
Blocks: 1219505
(Assignee)

Comment 2

2 years ago
This was an accidental change from bug 1193926. The fix is simple but we should get a testcase for this too.
Assignee: nobody → dtownsend
Blocks: 1193926
No longer blocks: 1219505, 1220911
(Assignee)

Updated

2 years ago
Blocks: 1219505
(Assignee)

Comment 3

2 years ago
Created attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Bug 1228359: Allow experiments to register chrome.
Attachment #8692624 - Flags: review?(felipc)
(Assignee)

Comment 4

2 years ago
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26291/diff/1-2/
Attachment #8692624 - Attachment description: MozReview Request: Bug 1228359: Allow experiments to register chrome. → MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

https://reviewboard.mozilla.org/r/26291/#review23745
Attachment #8692624 - Flags: review?(felipc) → review+

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9aa64c29bccc
(Assignee)

Comment 7

2 years ago
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Approval Request Comment
[Feature/regressing bug #]: Bug 1193926
[User impact if declined]: Experiments will be a little harder to write than normal. We might have broken existing experiment code.
[Describe test coverage new/current, TreeHerder]: About to land, the fix is dead simple though
[Risks and why]: No risks
[String/UUID change made/needed]: None
Attachment #8692624 - Flags: approval-mozilla-beta?
Attachment #8692624 - Flags: approval-mozilla-aurora?
Backed out for Windows XPCshell bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=247bfa7ed091

Failure: https://treeherder.mozilla.org/logviewer.html#?job_id=17897155&repo=mozilla-inbound

TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | AddonListener.onOperationCancelled - [AddonListener.onOperationCancelled : 1357] "onOperationCancelled" == "onInstalled"
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | InstallListener.onInstallFailed - [InstallListener.onInstallFailed : 1419] "onInstallFailed" == "onInstallEnded"
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_experiment.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_experiment.js | test_checkCompatibility - [test_checkCompatibility : 1574] 4 == 3
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_mapURIToAddonID.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_mapURIToAddonID.js | run_test_7 - NS_ERROR_FILE_ACCESS_DENIED: Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]
TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_temporary.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_system_update.js | xpcshell return code: 0

13:24:50     INFO -  TEST-PASS | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | observe - [observe : 223] true == true
13:24:50     INFO -  PROCESS | 11472 | 1448573090451	addons.xpi	ERROR	Failed to create directory c:\\users\\cltbld\\appdata\\local\\temp\\xpc-profile-pfbqbi\\extensions\\bootstrap1@tests.mozilla.org: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: SIO_installDirectory :: line 422"  data: no] Stack trace: SIO_installDirectory()@resource://gre/modules/addons/XPIProvider.jsm:422 < SIO_installDirEntry()@resource://gre/modules/addons/XPIProvider.jsm:486 < SIO_move()@resource://gre/modules/addons/XPIProvider.jsm:509 < DirInstallLocation_installAddon()@resource://gre/modules/addons/XPIProvider.jsm:7601 < AI_startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5949 < TaskImpl_run()@resource://gre/modules/Task.jsm:330 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813
13:24:50     INFO -  PROCESS | 11472 | 1448573090452	addons.xpi	ERROR	Failure moving c:\\users\\cltbld\\appdata\\local\\temp\\xpc-profile-pfbqbi\\extensions\\staged\\bootstrap1@tests.mozilla.org to c:\\users\\cltbld\\appdata\\local\\temp\\xpc-profile-pfbqbi\\extensions
13:24:50     INFO -  PROCESS | 11472 | 1448573090453	addons.xpi	WARN	Failed to install C:\\slave\\test\\build\\tests\\xpcshell\\tests\\toolkit\\mozapps\\extensions\\test\\xpcshell\\addons\\test_bootstrap1_2.xpi from file:///C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/addons/test_bootstrap1_2.xpi: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: SIO_rollback :: line 572"  data: no] Stack trace: SIO_rollback()@resource://gre/modules/addons/XPIProvider.jsm:572 < SIO_move()@resource://gre/modules/addons/XPIProvider.jsm:512 < DirInstallLocation_installAddon()@resource://gre/modules/addons/XPIProvider.jsm:7601 < AI_startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5949 < TaskImpl_run()@resource://gre/modules/Task.jsm:330 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813
13:24:50     INFO -  PROCESS | 11472 | 1448573090454	addons.xpi	WARN	removeActiveInstall: could not find active install for file:///C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/addons/test_bootstrap1_2.xpi
13:24:50     INFO -  "Got onOperationCancelled event for bootstrap1@tests.mozilla.org"
13:24:50  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | AddonListener.onOperationCancelled - [AddonListener.onOperationCancelled : 1357] "onOperationCancelled" == "onInstalled"
Flags: needinfo?(dtownsend)
(Assignee)

Updated

2 years ago
Flags: needinfo?(dtownsend)
Attachment #8692624 - Flags: approval-mozilla-beta?
Attachment #8692624 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 9

2 years ago
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26291/diff/2-3/
(Assignee)

Comment 10

2 years ago
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

For some reason retaining references to nsIFiles in the tests was causing file locking issues on windows. That seems odd but we don't have to retain those references so this is the simple fix.
Attachment #8692624 - Flags: review+ → review?(felipc)
Attachment #8692624 - Flags: review?(felipc) → review+
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

https://reviewboard.mozilla.org/r/26291/#review23813

Comment 12

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/a5ad0e73b4bf
(Assignee)

Comment 13

2 years ago
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Approval Request Comment: See comment 7
Attachment #8692624 - Flags: approval-mozilla-beta?
Attachment #8692624 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/a5ad0e73b4bf
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Important to keep experiments working, please uplift to aurora and beta
Attachment #8692624 - Flags: approval-mozilla-beta?
Attachment #8692624 - Flags: approval-mozilla-beta+
Attachment #8692624 - Flags: approval-mozilla-aurora?
Attachment #8692624 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/e576dd92d0f2

This has conflicts on beta that'll need to be resolved.
status-firefox44: affected → fixed
Flags: needinfo?(dtownsend)
Mossop will try to fix this up for beta 9, which goes to build thursday morning.
(Assignee)

Comment 18

2 years ago
Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26291/diff/3-4/
(Assignee)

Comment 19

2 years ago
Created attachment 8694345 [details] [diff] [review]
beta patch
Flags: needinfo?(dtownsend)
Attachment #8694345 - Flags: review?(felipc)
Attachment #8694345 - Flags: review?(felipc) → review+
(Assignee)

Comment 20

2 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/2ce1209499f8
status-firefox43: affected → fixed

Comment 21

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e576dd92d0f2
status-b2g-v2.5: --- → fixed
Adding tracking flag since this was a regression - just in case it reopens.
tracking-firefox43: ? → +
tracking-firefox44: ? → +
You need to log in before you can comment on or make changes to this bug.