1228488 - Pass WEBLG2 gl-enum-test test

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Return INVALID_ENUM for GL_UNIFORM_NAME_LENGTH.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8692822 [details] [diff] [review]
Return INVALID_ENUM for GL_UNIFORM_NAME_LENGTH.

Review of attachment 8692822 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextUniforms.cpp
@@ +325,5 @@
>      if (IsContextLost())
>          return;
>  
> +    if (pname == LOCAL_GL_UNIFORM_NAME_LENGTH)
> +        return ErrorInvalidEnumInfo("getActiveUniforms: pname", pname);

Please write this out as:

if (...) {
    ErrorFoo(...);
    return;
}

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5c79d93504

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a5c79d93504