1228497 - [Static Analysis][Uninitialized Members In Class] Class nsCSPParser from nsCSPParser.cpp has 3 member variables unintialized

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added the following in class nsCSPParser:

1. uninit_member: Non-static class member mCurChar is not initialized in this constructor nor in any functions that it calls.
2. uninit_member: Non-static class member mEndChar is not initialized in this constructor nor in any functions that it calls.
3. uninit_member: Non-static class member mPolicy is not initialized in this constructor nor in any functions that it calls.

Comment 1

[Andi [:andi]]

Attachment: Bug 1228497.diff

Hello Sid,

Could you please take a look other this patch and tell me what you think?

THX

Comment 2

[Sid Stamm [:geekboy or :sstamm]]

Comment on attachment 8692815 [details] [diff] [review]
Bug 1228497.diff

Review of attachment 8692815 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I think it would be good to initialize those.  Chris, you wrote most of the parser; this makes sense, right?

Comment 3

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

Comment on attachment 8692815 [details] [diff] [review]
Bug 1228497.diff

Review of attachment 8692815 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/security/nsCSPParser.cpp
@@ +131,5 @@
>   , mCSPContext(aCSPContext)
>   , mDeliveredViaMetaTag(aDeliveredViaMetaTag)
> + , mCurChar(nullptr)
> + , mEndChar(nullptr)
> + , mPolicy(nullptr)

Yeah, that sounds great, but the initialization list needs to match the order of the members in the *.h file, otherwise they will be initialized after object construction.

Comment 4

[Andi [:andi]]

Attachment: Bug 1228497.diff

Thanks for catching that, otherwise the build would have crashed since we are treating this compile warnings as errors, witch is good!

Comment 5

[Christoph Kerschbaumer [:ckerschb, back Sept 8th]]

Comment on attachment 8697187 [details] [diff] [review]
Bug 1228497.diff

Review of attachment 8697187 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, r=me

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d260fdcb9f8f

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d260fdcb9f8f