Closed Bug 1228510 Opened 8 years ago Closed 8 years ago

[Static Analysis][Uninitialized Members In Class] Class PushedGroup from BasicLayers.h has some uninitialized variables

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1340249)

Attachments

(1 file)

Bug 1228510.diff
1.06 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review 
The Static Analysis tool Coverity added that variables mOperator and mOpacity from PushedGroup  are not initialized.
Whiteboard: CID 1340249
Attached patch Bug 1228510.diff — — Splinter Review 
Hello Jeff,

Could you please take a look other this patch?

THX
Attachment #8692839 - Flags: review?(jmuizelaar)
Attachment #8692839 - Flags: review?(jmuizelaar) → review?(bas)
Comment on attachment 8692839 [details] [diff] [review]
Bug 1228510.diff

Review of attachment 8692839 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure we need/want to initialize them.. but in the end it hardly matters.
Attachment #8692839 - Flags: review?(bas) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8d04ecd5ad59
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.