1228634 - Implement Element.getAttributeNames

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

This is a recent addition to the DOM spec.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://github.com/whatwg/dom/issues/115

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://dom.spec.whatwg.org/#dom-element-getattributenames

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8693060 [details] [diff] [review]
v1

Review of attachment 8693060 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/dom/nodes/attributes.html
@@ +409,5 @@
> +  el.setAttributeNS("", "FOO", "bar");
> +  el.setAttributeNS("dummy1", "foo", "bar");
> +  el.setAttributeNS("dummy2", "dummy:foo", "bar");
> +  assert_equals(el.getAttributeNames().length, 4);
> +  assert_equals(el.getAttributeNames()[0], "foo");

FWIW, this could use `assert_array_equals(el.getAttributeNames(), ["foo", "FOO", "foo", "dummy:foo"]);

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

ah, thanks, will use that next time I'll write this kind of wpt.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b338dbd8c9df

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b338dbd8c9df