Closed Bug 1228634 Opened 4 years ago Closed 4 years ago

Implement Element.getAttributeNames

Categories

(Core :: DOM: Core & HTML, defect)

36 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

This is a recent addition to the DOM spec.
Attached patch v1Splinter Review
Attachment #8693060 - Flags: review?(peterv)
Comment on attachment 8693060 [details] [diff] [review]
v1

Review of attachment 8693060 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/dom/nodes/attributes.html
@@ +409,5 @@
> +  el.setAttributeNS("", "FOO", "bar");
> +  el.setAttributeNS("dummy1", "foo", "bar");
> +  el.setAttributeNS("dummy2", "dummy:foo", "bar");
> +  assert_equals(el.getAttributeNames().length, 4);
> +  assert_equals(el.getAttributeNames()[0], "foo");

FWIW, this could use `assert_array_equals(el.getAttributeNames(), ["foo", "FOO", "foo", "dummy:foo"]);
ah, thanks, will use that next time I'll write this kind of wpt.
Attachment #8693060 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/b338dbd8c9df
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.