Closed Bug 1228703 Opened 4 years ago Closed 4 years ago

Enable rust for MacOS X nightly builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(3 files, 3 obsolete files)

Turns out bug 1183850 only enabled rust for mac debug builds, so the rust code isn't getting active testing in the Nightly population. We should turn it on there too.
Initial patch.

The mac opt builds use the macosx-universal mozconfigs, building both 32 and 64 bit versions. This patch fails in the 32 bit configure when the rust link check fails to find 32 bit symbols. So we either need to pass --target=i686-apple-darwin to rustc in this case, or make the mozconfig.rust inclusion conditional to exclude 32-bit.

Either is fine in the short term, the building for both archs is the correct long-term fix.
I say we go the 64-bit only route, as we'd like to make 32-bit OS X builds go away in the not-too-distant future.
Ok, great. Do you know what I can check for the target in the mozconfig?
Try setting the cross triple for the universal build in client.mk based on MOZ_CURRENT_TARGET. We don't get to find out if this works because we still fail on configure's link test which happens before this.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72b2a84ec531&selectedJob=14282124
Next idea: check for HAVE_64BIT_BUILD in configure and append the 32-bit triple to RUSTC if it's not set and we're building on Mac.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c660a4ac69a9
Attachment #8695373 - Attachment is obsolete: true
Set cross triple in configure based on HAVE_64BIT_BUILD. This method works.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=557a5d3ca194&selectedJob=14432388
Attachment #8695383 - Attachment is obsolete: true
Attachment #8696174 - Flags: review?(mshal)
Attachment #8693143 - Attachment is obsolete: true
Attachment #8696175 - Flags: review?(mshal)
Attachment #8696171 - Flags: review?(mshal) → review+
Attachment #8696174 - Flags: review?(mshal) → review+
Comment on attachment 8696175 [details] [diff] [review]
Part 3 - Enable rust for MacOS X nightly builds

>Subject: Bug 1228703 - Enable rust for MacOS X nightly builds. r?mhal

mhal -> mshal :)

Everything looks good to me.
Attachment #8696175 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #10)

> mhal -> mshal :)

Oops, sorry! Thanks for the meeting-time review. :)
Blocks: 1243363
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.