1228703 - Enable rust for MacOS X nightly builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Turns out bug 1183850 only enabled rust for mac debug builds, so the rust code isn't getting active testing in the Nightly population. We should turn it on there too.

Comment 1

[Ralph Giles (:rillian)]

Attachment: WIP: Enable rust in mac nightly builds v1

Initial patch.

The mac opt builds use the macosx-universal mozconfigs, building both 32 and 64 bit versions. This patch fails in the 32 bit configure when the rust link check fails to find 32 bit symbols. So we either need to pass --target=i686-apple-darwin to rustc in this case, or make the mozconfig.rust inclusion conditional to exclude 32-bit.

Either is fine in the short term, the building for both archs is the correct long-term fix.

Comment 2

[Nathan Froyd [:froydnj]]

I say we go the 64-bit only route, as we'd like to make 32-bit OS X builds go away in the not-too-distant future.

Comment 3

[Ralph Giles (:rillian)]

Ok, great. Do you know what I can check for the target in the mozconfig?

Comment 4

[Ralph Giles (:rillian)]

Attachment: Pass 32 bit triple to rustc when targetting

Try setting the cross triple for the universal build in client.mk based on MOZ_CURRENT_TARGET. We don't get to find out if this works because we still fail on configure's link test which happens before this.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72b2a84ec531&selectedJob=14282124

Comment 5

[Ralph Giles (:rillian)]

Attachment: Append 32 bit triple to RUSTC when crossing.

Next idea: check for HAVE_64BIT_BUILD in configure and append the 32-bit triple to RUSTC if it's not set and we're building on Mac.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c660a4ac69a9

Comment 6

[Ralph Giles (:rillian)]

Attachment: Part 1 - tooltool bump to rustc with 32-bit cross support

Comment 7

[Ralph Giles (:rillian)]

Attachment: Part 2 - Pass 32-bit triple when building universal Mac target

Set cross triple in configure based on HAVE_64BIT_BUILD. This method works.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=557a5d3ca194&selectedJob=14432388

Comment 8

[Ralph Giles (:rillian)]

Attachment: Part 3 - Enable rust for MacOS X nightly builds

Comment 9

[Ralph Giles (:rillian)]

Full try push looks ok. https://treeherder.mozilla.org/#/jobs?repo=try&revision=f45c20e27f4f&selectedJob=14441544

Comment 10

[Michael Shal [:mshal]]

Comment on attachment 8696175 [details] [diff] [review]
Part 3 - Enable rust for MacOS X nightly builds

>Subject: Bug 1228703 - Enable rust for MacOS X nightly builds. r?mhal

mhal -> mshal :)

Everything looks good to me.

Comment 11

[Ralph Giles (:rillian)]

(In reply to Michael Shal [:mshal] from comment #10)

> mhal -> mshal :)

Oops, sorry! Thanks for the meeting-time review. :)

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0920d7f00a0
https://hg.mozilla.org/integration/mozilla-inbound/rev/90136d8f3801
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc8ecea2a286

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a0920d7f00a0
https://hg.mozilla.org/mozilla-central/rev/90136d8f3801
https://hg.mozilla.org/mozilla-central/rev/bc8ecea2a286