Closed
Bug 1228711
Opened 10 years ago
Closed 10 years ago
Cubemap images should be square ("Assertion failure: false (Unexpected GL error.)")
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: jruderman, Assigned: jgilbert)
Details
(Keywords: assertion, reproducible, testcase, Whiteboard: gfx-noted)
Attachments
(5 files, 1 obsolete file)
Assertion failure: false (Unexpected GL error.), at dom/canvas/WebGLTextureUpload.cpp:1130
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
I can easily reproduce this on mac.
Keywords: reproducible
Whiteboard: gfx-noted
Comment 3•10 years ago
|
||
JavaScript warning: https://bug1228711.bmoattachments.org/attachment.cgi?id=8693165, line 11: Error: WebGL: texImage2D: Unexpected error during upload: 0x0501
texImage2D: dui: 1908/1908/8033
Assertion failure: false (Unexpected GL error.), at /Users/bgirard/mozilla/mozilla-central/tree/dom/canvas/WebGLTextureUpload.cpp:1130
Comment 4•10 years ago
|
||
0x0501 = GL_INVALID_VALUE
0x1908 = GL_RGBA
0x8033 = GL_UNSIGNED_SHORT_4_4_4_4
Assignee | ||
Comment 6•10 years ago
|
||
I am stunned that this isn't tested. It's an INVALID_VALUE because it's a cubemap texImage specification that's non-square.
Assignee: nobody → jgilbert
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8695567 -
Attachment is obsolete: true
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8695569 -
Flags: review?(bgirard)
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8695570 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8695570 [details] [diff] [review]
0002-Cubemap-images-must-be-square.patch
Review of attachment 8695570 [details] [diff] [review]:
-----------------------------------------------------------------
:benwa can get this.
Attachment #8695570 -
Flags: review?(dglastonbury) → review?(bgirard)
Updated•10 years ago
|
Attachment #8695569 -
Flags: review?(bgirard) → review+
Comment 12•10 years ago
|
||
Comment on attachment 8695570 [details] [diff] [review]
0002-Cubemap-images-must-be-square.patch
Review of attachment 8695570 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8695570 -
Flags: review?(bgirard) → review+
Comment 13•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Summary: "Assertion failure: false (Unexpected GL error.)" → Cubemap images should be square ("Assertion failure: false (Unexpected GL error.)")
Comment 14•10 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•