Closed Bug 1228711 Opened 7 years ago Closed 7 years ago

Cubemap images should be square ("Assertion failure: false (Unexpected GL error.)")

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: jruderman, Assigned: jgilbert)

Details

(Keywords: assertion, reproducible, testcase, Whiteboard: gfx-noted)

Attachments

(5 files, 1 obsolete file)

testcase
358 bytes, text/html
Details
stack
12.14 KB, text/plain
Details
test_cubemap_must_be_square.solo.html
5.51 KB, text/html
Details
0001-Add-a-test.patch
2.09 KB, patch
BenWa
: review+
Details | Diff | Splinter Review
0002-Cubemap-images-must-be-square.patch
1.00 KB, patch
BenWa
: review+
Details | Diff | Splinter Review
Attached file testcase — 
Assertion failure: false (Unexpected GL error.), at dom/canvas/WebGLTextureUpload.cpp:1130
Attached file stack — 
I can easily reproduce this on mac.
Keywords: reproducible
Whiteboard: gfx-noted
JavaScript warning: https://bug1228711.bmoattachments.org/attachment.cgi?id=8693165, line 11: Error: WebGL: texImage2D: Unexpected error during upload: 0x0501
texImage2D: dui: 1908/1908/8033
Assertion failure: false (Unexpected GL error.), at /Users/bgirard/mozilla/mozilla-central/tree/dom/canvas/WebGLTextureUpload.cpp:1130
0x0501 = GL_INVALID_VALUE
0x1908 = GL_RGBA
0x8033 = GL_UNSIGNED_SHORT_4_4_4_4
What should webgl be doing with these values?
Flags: needinfo?(jgilbert)
I am stunned that this isn't tested. It's an INVALID_VALUE because it's a cubemap texImage specification that's non-square.
Assignee: nobody → jgilbert
Flags: needinfo?(jgilbert)
Attachment #8695569 - Flags: review?(bgirard)
Comment on attachment 8695570 [details] [diff] [review]
0002-Cubemap-images-must-be-square.patch

Review of attachment 8695570 [details] [diff] [review]:
-----------------------------------------------------------------

:benwa can get this.
Attachment #8695570 - Flags: review?(dglastonbury) → review?(bgirard)
Attachment #8695569 - Flags: review?(bgirard) → review+
Comment on attachment 8695570 [details] [diff] [review]
0002-Cubemap-images-must-be-square.patch

Review of attachment 8695570 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8695570 - Flags: review?(bgirard) → review+
Summary: "Assertion failure: false (Unexpected GL error.)" → Cubemap images should be square ("Assertion failure: false (Unexpected GL error.)")
https://hg.mozilla.org/mozilla-central/rev/5cd268005144
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.