Closed Bug 1228739 Opened 10 years ago Closed 10 years ago

Clean up .gitignore

Categories

(Tree Management :: Treeherder, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
wlach
: review+
Details | Review
There are unnecessary entries in the .gitignore, which we should clean up. This would avoid: 01:28 <wlach|afk> here's a tale for the ages 01:28 <wlach|afk> so I'm wondering "why is performance parsing broken" 01:29 <wlach|afk> (this is on my vagrant instance) 01:29 <wlach|afk> think it's something obscure and complicated 01:29 <wlach|afk> after an hour of debugging all the way down to the log parser level, I realize I still have leftover files from when we were using cython to precompile the logparser 01:29 <wlach|afk> and thus it didn't understand the new-style performance blobs I'm presuming they were .pyo files. (When Cython support was removed, *.c and *.so entries were removed from the .gitignore, but guessing that's not enough)
Attached file Clean up .gitignore
Attachment #8693215 - Flags: review?(wlachance)
Comment on attachment 8693215 [details] [review] Clean up .gitignore Not sure if it would have helped my problem, as I didn't even think to look at `git status`. But anyway, this looks great, thanks.
Attachment #8693215 - Flags: review?(wlachance) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/31c5bdca672c9d8f8283d5abdb0d49d71660bd46 Bug 1228739 - Remove unnecessary .gitignore entries & clean up ordering Removed: *.mo *.py[od] .coverage .mr.developer.cfg .project .pydevproject .tmp/ .tox htmlcov/ LOGFILE nosetests.xml pip-log.txt supervisor*.log test.log treeherder*.log treeherder.log.*
(In reply to William Lachance (:wlach) from comment #2) > Not sure if it would have helped my problem, as I didn't even think to look > at `git status`. But anyway, this looks great, thanks. I thought things like git rebase failed to run if there were uncommitted changes in the working directory? Though maybe that doesn't apply for files that are not git-tracked. I guess there's not much we can do about reminding people to check the output of `git status`. I use SourceTree about half the time, which makes it very clear when the working directory is modified (and what files have changed), which helps make it harder to miss.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: