1228801 - tab-content.js, line 518: NS_ERROR_MALFORMED_URI [PageStyleHandler::_filterStyleSheets]

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jesse Ruderman]

Attachment: testcase

JavaScript error: chrome://browser/content/tab-content.js, line 518: NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]

The throwing line was added to tab-content.js in:

changeset:   https://hg.mozilla.org/mozilla-central/rev/588505e93ed0
user:        Mike Conley
date:        Fri Oct 02 10:03:51 2015 -0400
summary:     Bug 1141041 - Stop using CPOWs for the Page Style menu. r=Gijs

Comment 1

[:Gijs (he/him)]

The throwing line is:

      let URI = Services.io.newURI(currentStyleSheet.href, null, null);

I'm assuming currentStyleSheet doesn't have an href because the testcase document has no stylesheets, only an inline style block. I'm guessing this creates an element inside document.styleSheets that has no href. It's all guessing because Firefox crashes when I try to use the js debugger to figure this out.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks Jesse - should be a straight-forward patch. Coming up once I test it.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1228801 - Handle malformed URIs in href for style tags in tab-content.js. r?Gijs

Bug 1228801 - Handle malformed URIs in href for style tags in tab-content.js. r?Gijs

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8693607 [details]
MozReview Request: Bug 1228801 - Handle malformed URIs in href for style tags in tab-content.js. r?Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26499/diff/1-2/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8693607 [details]
MozReview Request: Bug 1228801 - Handle malformed URIs in href for style tags in tab-content.js. r?Gijs

https://reviewboard.mozilla.org/r/26499/#review23929

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Thanks for the fast review!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/integration/fx-team/rev/2356e43e24b881410bc3991466378ce2db8991b3
Bug 1228801 - Handle malformed URIs in href for style tags in tab-content.js. r=Gijs

Comment 8

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

Bug 1141041 landed in 44, so this affects that version as well. I'm not sure this is serious enough to warrant an uplift[1], but requesting tracking just the same.

[1]: The only user-visible consequences I can think of is that we don't properly list alternative stylesheets for sites that include <style> tags with invalid URLs in their href attributes.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2356e43e24b8

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Given the user impact mentioned in comment 8, I think we can let this one ride the Aurora45 -> Beta45 to release train. Untracked and wontfix for 44.