Closed Bug 1228876 Opened 4 years ago Closed 4 years ago

"ASSERTION: Options collection broken"

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
###!!! ASSERTION: Options collection broken: 'opt == mOptions->ItemAsOption(index++)', file dom/html/HTMLSelectElement.cpp, line 1832
Attached file stack
Gah.  This is a regression from bug 1214164.
Blocks: 1214164
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8693736 [details] [diff] [review]
Correctly ignore nested optgroups even if an optgroup is inserted into another, existing, optgroup

Looks good.  r=mats

Perhaps also add "document.body.appendChild(a)" at the end of boom()
to subject this evilness to layout too?
Attachment #8693736 - Flags: review?(mats) → review+
> Perhaps also add "document.body.appendChild(a)" at the end of boom()

Done.
https://hg.mozilla.org/mozilla-central/rev/c1e96f06682a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.