1228893 - JSON Viewer says BMO's configuration JSON is invalid, but it doesn't seem to be.

Status: VERIFIED WORKSFORME

(DevTools :: JSON Viewer, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If I load https://bugzilla.mozilla.org/config.cgi?ctype=json without devtools.jsonview.enabled set to true, the full json loads in a tab. If I select it all, copy, and paste it into http://jsonlint.com/ it says that it is valid JSON.

But if I flip that pref and load the JSON in the JSON Viewer, it gives me an error:
SyntaxError: JSON.parse: unterminated string at line 31725 column 14 of the JSON data

Looking in the "Raw Data" section, it looks like the JSON just cuts off somewhere in the middle of the data.

It shouldn't do that.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This is on a mostly-current Nightly, in an e10s window. (I've also bumped dom.ipc.processCount up to 25 so each of my tabs gets its own plugin-container process, if that matters...)

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I consistently get this error:

SyntaxError: JSON.parse: end of data while reading object contents at line 31727 column 1 of the JSON data

The JSON output from the server is 77,269 lines long, not 31,727 - seems like the JSON viewer is getting truncated data. 

( I don't think your processCount has anything to do with it. )

ni'ing Honza: is this a known size limitation of the viewer? If so we should produce a better error at the very least.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There is a problem with converting data from HTTP stream, I am seeing an error:

Honza, this looks like a platform bug. The nsIConverterInputStream returns 0 when calling readString() even if there are still some bytes to read.

STR:
1) Install Nightly, switch to e10s and make sure `devtools.jsonview.enabled` pref is set to true
2) Load https://bugzilla.mozilla.org/config.cgi?ctype=json
3) Instead of displaying JSON tree, there is an error message:

SyntaxError: JSON.parse: unexpected end of data at line 32243 column 2 of the JSON data

And the browser console says:
Error: Stream converter failed to read the input stream!

The problem is this exception (in JSON Viewer):
https://github.com/mozilla/gecko-dev/blob/master/devtools/client/jsonview/converter-child.js#L88

I don't see any reason why it should fail.

Honza

Comment 4

[UKS]

I have tested this via JSONView add-on and it loaded the entire JSON structure without any error. Unless I am mistaken it seems to work for me when I tested. See attachments of the browser I tested with.

Comment 5

[UKS]

Sorry I cannot attach so I am pasting it here.

Application Basics
------------------

Name: Firefox
Version: 44.0b2
Build ID: 20151221151411
Update Channel: beta
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:44.0) Gecko/20100101 Firefox/44.0
Multiprocess Windows: 0/1 (default: false)
Safe Mode: false

Crash Reports for the Last 3 Days
---------------------------------

All Crash Reports

Extensions
----------

Name: JSONView
Version: 1.1.0
Enabled: true
ID: [e-mail]

Graphics
--------

Asynchronous Pan/Zoom: none
Device ID: 0x0a2e
GPU Accelerated Windows: 1/1 OpenGL (OMTC)
Supports Hardware H264 Decoding: No;
Vendor ID: 0x8086
WebGL Renderer: Intel Inc. -- Intel Iris OpenGL Engine
windowLayerManagerRemote: true
AzureCanvasBackend: skia
AzureContentBackend: quartz
AzureFallbackCanvasBackend: none
AzureSkiaAccelerated: 1

Important Modified Preferences
------------------------------

accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 358400
browser.cache.disk.filesystem_reported: 1
browser.cache.disk.smart_size_cached_value: 358400
browser.cache.disk.smart_size.first_run: false
browser.cache.disk.smart_size.use_old_max: false
browser.cache.frecency_experiment: 2
browser.download.importedFromSqlite: true
browser.places.smartBookmarksVersion: 7
browser.privatebrowsing.autostart: true
browser.sessionstore.upgradeBackup.latestBuildID: 20140911151253
browser.startup.homepage_override.buildID: 20151221151411
browser.startup.homepage_override.mstone: 44.0
dom.apps.reset-permissions: true
dom.mozApps.used: true
extensions.lastAppVersion: 44.0
font.internaluseonly.changed: true
font.language.group: x-western
font.name.serif.x-cyrillic: American Typewriter
gfx.blacklist.direct2d: 3
gfx.crash-guard.glcontext.appVersion: 44.0
gfx.crash-guard.glcontext.deviceID: 0x0a2e
gfx.crash-guard.status.glcontext: 2
media.gmp-gmpopenh264.lastUpdate: 1450541892
media.gmp-gmpopenh264.version: 1.5.1
media.gmp-manager.buildID: 20151221151411
media.gmp-manager.lastCheck: 1450843779
network.cookie.prefsMigrated: true
network.predictor.cleaned-up: true
places.database.lastMaintenance: 1450541850
places.history.expiration.transient_current_max_pages: 104858
plugin.disable_full_page_plugin_for_types: application/pdf
plugin.importedState: true
privacy.sanitize.migrateClearSavedPwdsOnExit: true
privacy.sanitize.migrateFx3Prefs: true
security.disable_button.openCertManager: false
storage.vacuum.last.index: 1
storage.vacuum.last.places.sqlite: 1450541850

Important Locked Preferences
----------------------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0

Library Versions
----------------

NSPR
Expected minimum version: 4.11
Version in use: 4.11

NSS
Expected minimum version: 3.21 Basic ECC
Version in use: 3.21 Basic ECC

NSSSMIME
Expected minimum version: 3.21 Basic ECC
Version in use: 3.21 Basic ECC

NSSSSL
Expected minimum version: 3.21 Basic ECC
Version in use: 3.21 Basic ECC

NSSUTIL
Expected minimum version: 3.21
Version in use: 3.21

Experimental Features
---------------------

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to UKS from comment #4)
> I have tested this via JSONView add-on and it loaded the entire JSON
> structure without any error. Unless I am mistaken it seems to work for me
> when I tested. See attachments of the browser I tested with.

I believe the issue is with e10s being enabled. When 44 was on Aurora, it had e10s turned on. Now that 44's moved to beta, e10s has been disabled.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1228893-1.patch

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8704148 [details] [diff] [review]
bug1228893-1.patch

Review of attachment 8704148 [details] [diff] [review]:
-----------------------------------------------------------------

Great, works here!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b2871e9a9deb

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b2871e9a9deb

Comment 11

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected