Update Loop's build configuration to use new Hierarchical structures from bug 1228444

RESOLVED FIXED in Firefox 46

Status

defect
P3
normal
Rank:
30
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: standard8, Assigned: glandium)

Tracking

unspecified
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 affected, firefox46 fixed)

Details

(Whiteboard: [tech-debt])

Attachments

(1 attachment)

Per bug 1223573 comment 19, we should use new forms for our moz.build file once bug 1228444 lands:

(In reply to Mike Hommey [:glandium] from comment #19)
> ::: browser/extensions/loop/moz.build
> @@ +11,5 @@
> > +]
> > +
> > +DIST_FILES += [
> > +  'install.rdf.in'
> > +]
> 
> I just got an idea to avoid setting FINAL_TARGET and use a more "natural",
> albeit a little more annoying construct:
> 
> FINAL_TARGET_FILES.features['loop@test.mozilla.org'] += [ 'bootstrap.js' ]
> DIST_FILES.features['loop@test.mozilla.org'] += ['install.rdf.in']
> 
> Then, in jar.mn:
> [features/loop@test.mozilla.org] chrome.jar:
> 
> (Note that DIST_FILES.something doesn't work yet, but it is logical to make
> it work, considering DIST_FILES is essentially meant to be the same as
> FINAL_TARGET_FILES with preprocessing, and FINAL_TARGET_FILES.something is
> supported, and I'm going to fix that just now)
Rank: 30
Depends on: 1228444
Blocks: 1223573
Whiteboard: [tech-debt][blocked] → [tech-debt]
Note this is a problem for l10n because of the hard coded dist/bin in FINAL_TARGET, so if you want loop to be localized, you'll have to fix this. Pocket is hitting the problem because it copied the constructs used by loop.
Assignee: nobody → mh+mozilla
Attachment #8702411 - Flags: review?(mshal)
No longer blocks: 1215694
Comment on attachment 8702411 [details] [diff] [review]
Avoid setting FINAL_TARGET in browser/extensions/loop/moz.build

Looks like the jar.py change already landed in bug 1215694.
Attachment #8702411 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/e50d851f973d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
backed out by request from sylvestre in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44
Flags: needinfo?(mh+mozilla)
(In reply to Carsten Book [:Tomcat] from comment #8)
> backed out by request from sylvestre in
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44

Your ni? is lacking context.
Flags: needinfo?(mh+mozilla) → needinfo?(cbook)
(In reply to Mike Hommey [:glandium] from comment #9)
> (In reply to Carsten Book [:Tomcat] from comment #8)
> > backed out by request from sylvestre in
> > https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44
> 
> Your ni? is lacking context.

we backed out the loop changes from beta for loop issues in the beta builds.
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.