1228998 - Update Loop's build configuration to use new Hierarchical structures from bug 1228444

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[Mark Banner (:standard8)]

Per bug 1223573 comment 19, we should use new forms for our moz.build file once bug 1228444 lands:

(In reply to Mike Hommey [:glandium] from comment #19)
> ::: browser/extensions/loop/moz.build
> @@ +11,5 @@
> > +]
> > +
> > +DIST_FILES += [
> > +  'install.rdf.in'
> > +]
> 
> I just got an idea to avoid setting FINAL_TARGET and use a more "natural",
> albeit a little more annoying construct:
> 
> FINAL_TARGET_FILES.features['[e-mail]'] += [ 'bootstrap.js' ]
> DIST_FILES.features['[e-mail]'] += ['install.rdf.in']
> 
> Then, in jar.mn:
> [features/[e-mail]] chrome.jar:
> 
> (Note that DIST_FILES.something doesn't work yet, but it is logical to make
> it work, considering DIST_FILES is essentially meant to be the same as
> FINAL_TARGET_FILES with preprocessing, and FINAL_TARGET_FILES.something is
> supported, and I'm going to fix that just now)

Comment 1

[Mike Hommey [:glandium]]

Note this is a problem for l10n because of the hard coded dist/bin in FINAL_TARGET, so if you want loop to be localized, you'll have to fix this. Pocket is hitting the problem because it copied the constructs used by loop.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Avoid setting FINAL_TARGET in browser/extensions/loop/moz.build

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8702411 [details] [diff] [review]
Avoid setting FINAL_TARGET in browser/extensions/loop/moz.build

Looks like the jar.py change already landed in bug 1215694.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e50d851f973d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e50d851f973d

Comment 6

[Mark Banner (:standard8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=149fdfdb40d1

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-beta/rev/149fdfdb40d1

Comment 8

[Carsten Book [:Tomcat]]

backed out by request from sylvestre in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44

Comment 9

[Mike Hommey [:glandium]]

(In reply to Carsten Book [:Tomcat] from comment #8)
> backed out by request from sylvestre in
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44

Your ni? is lacking context.

Comment 10

[Carsten Book [:Tomcat]]

(In reply to Mike Hommey [:glandium] from comment #9)
> (In reply to Carsten Book [:Tomcat] from comment #8)
> > backed out by request from sylvestre in
> > https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44
> 
> Your ni? is lacking context.

we backed out the loop changes from beta for loop issues in the beta builds.

Comment 11

[Mark Banner (:standard8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6dc2d1c7f5e