Closed Bug 1228999 Opened 4 years ago Closed 4 years ago

Undo css workaround for AUTHOR_SHEETS not working correctly when bug lands

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
2

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Iteration:
45.3 - Dec 14
Tracking Status
firefox45 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

When bug 1228542 lands, we should backout some of attachment 8692987 [details] [diff] [review] (part of bug 1223573).

We shouldn't back out all of it. We want to:

- Drop the !important attributes
- Change USER_SHEET back to AUTHOR_SHEET in bootstrap.js

We'll then need to re-verify that the styles for the following still look ok on all platforms:

- Hello button (various states), also when in customise & the menu panel
- Conversation window toolbar (not popped-out state)
Rank: 28
I have a try push running with the fix for this to check we don't get the errors again:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e84a7f3216f
Assignee: nobody → standard8
The core issue has been fixed, and the try results look good, so lets take out the workarounds.
Attachment #8694949 - Flags: review?(mdeboer)
Comment on attachment 8694949 [details] [diff] [review]
Undo css workaround in Loop's system-addon that was necessary as AUTHOR_SHEETS were previously not working correctly.

Review of attachment 8694949 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Thanks to Gabor for such a quick fix!
Attachment #8694949 - Flags: review?(mdeboer) → review+
Status: NEW → ASSIGNED
Iteration: --- → 45.3 - Dec 14
Points: --- → 2
Whiteboard: [tech-debt][blocked] → [tech-debt]
Blocks: 1223573
https://hg.mozilla.org/mozilla-central/rev/cd2a99c12ed3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.