1228999 - Undo css workaround for AUTHOR_SHEETS not working correctly when bug lands

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

When bug 1228542 lands, we should backout some of attachment 8692987 [details] [diff] [review] (part of bug 1223573).

We shouldn't back out all of it. We want to:

- Drop the !important attributes
- Change USER_SHEET back to AUTHOR_SHEET in bootstrap.js

We'll then need to re-verify that the styles for the following still look ok on all platforms:

- Hello button (various states), also when in customise & the menu panel
- Conversation window toolbar (not popped-out state)

Comment 1

[Mark Banner (:standard8)]

I have a try push running with the fix for this to check we don't get the errors again:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e84a7f3216f

Comment 2

[Mark Banner (:standard8)]

Attachment: Undo css workaround in Loop's system-addon that was necessary as AUTHOR_SHEETS were previously not working correctly.

The core issue has been fixed, and the try results look good, so lets take out the workarounds.

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8694949 [details] [diff] [review]
Undo css workaround in Loop's system-addon that was necessary as AUTHOR_SHEETS were previously not working correctly.

Review of attachment 8694949 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Thanks to Gabor for such a quick fix!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cd2a99c12ed3

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cd2a99c12ed3