Make async TCP driver protocol 3 compatible

RESOLVED FIXED

Status

Testing
JSMarionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The asynchronous TCP driver in tests/jsmarionette/client/marionette-client/lib/marionette/drivers/abstract.js is not compatible with Marionette protocol level 3 that will get introduced in bug 1211489.

This causes tests/jsmarionette/runner/marionette-js-runner/test/integration/clientasync.js to fail with bug 1211489 is applied to Gecko.

To fix this issue we apply the same logic from the synchronous TCP driver to marshal and unmarshal messages when talking to a protocol level 3 server.
(Assignee)

Updated

2 years ago
Assignee: nobody → ato
Blocks: 1211489
Status: NEW → ASSIGNED
Created attachment 8693569 [details] [review]
[gaia] andreastt:bug_1229011 > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8693569 - Flags: review?(aus)

Comment 2

2 years ago
Comment on attachment 8693569 [details] [review]
[gaia] andreastt:bug_1229011 > mozilla-b2g:master

LGTM! Ship it! :)
Attachment #8693569 - Flags: review?(aus) → review+
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla-b2g/gaia/commit/e6ff297ea34420bbe74f155fb52eb81e173f2644
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.