Closed Bug 1229011 Opened 9 years ago Closed 9 years ago

Make async TCP driver protocol 3 compatible

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

[gaia] andreastt:bug_1229011 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
aus
: review+
Details | Review 
The asynchronous TCP driver in tests/jsmarionette/client/marionette-client/lib/marionette/drivers/abstract.js is not compatible with Marionette protocol level 3 that will get introduced in bug 1211489.

This causes tests/jsmarionette/runner/marionette-js-runner/test/integration/clientasync.js to fail with bug 1211489 is applied to Gecko.

To fix this issue we apply the same logic from the synchronous TCP driver to marshal and unmarshal messages when talking to a protocol level 3 server.
Assignee: nobody → ato
Blocks: 1211489
Status: NEW → ASSIGNED
Attachment #8693569 - Flags: review?(aus)
Comment on attachment 8693569 [details] [review]
[gaia] andreastt:bug_1229011 > mozilla-b2g:master

LGTM! Ship it! :)
Attachment #8693569 - Flags: review?(aus) → review+
https://github.com/mozilla-b2g/gaia/commit/e6ff297ea34420bbe74f155fb52eb81e173f2644
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: