Closed
Bug 1229011
Opened 10 years ago
Closed 10 years ago
Make async TCP driver protocol 3 compatible
Categories
(Testing Graveyard :: JSMarionette, defect)
Testing Graveyard
JSMarionette
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(1 file)
The asynchronous TCP driver in tests/jsmarionette/client/marionette-client/lib/marionette/drivers/abstract.js is not compatible with Marionette protocol level 3 that will get introduced in bug 1211489.
This causes tests/jsmarionette/runner/marionette-js-runner/test/integration/clientasync.js to fail with bug 1211489 is applied to Gecko.
To fix this issue we apply the same logic from the synchronous TCP driver to marshal and unmarshal messages when talking to a protocol level 3 server.
|
Assignee | |
Updated•10 years ago
|
|
||
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8693569 -
Flags: review?(aus)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8693569 [details] [review]
[gaia] andreastt:bug_1229011 > mozilla-b2g:master
LGTM! Ship it! :)
Attachment #8693569 -
Flags: review?(aus) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•