Make treeherder-client log output less verbose by switching headers/request body to log.debug

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Will reduce the verbosity of logs for bug 1229020.
Also avoids dumping hawk hashes to logs (though these can't be used directly, since they have to be brute forced, but still).
(Assignee)

Updated

3 years ago
Depends on: 1229025
(Assignee)

Comment 1

3 years ago
Created attachment 8693615 [details] [review]
Make treeherder-client HTTPError output less verbose
Attachment #8693615 - Flags: review?(mdoglio)
Attachment #8693615 - Flags: review?(mdoglio) → review+

Comment 2

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ca24ba6d419f6e877b1ca6194321b64b024523c2
Bug 1229022 - Make treeherder-client HTTPError output less verbose

The request body, request headers & response headers are now output with
a log level of `debug` rather than `error`, to reduce verbosity of logs.

In addition, the response body has now been combined with the log line
that outputs the URL, to make it easier to correlate lines in the log.
The type in the `_get_json()` ("Error *submitting* data") has also been
fixed, and string substitution now occurs lazily.
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1236957
You need to log in before you can comment on or make changes to this bug.