1229051 - Reenable C++ unit tests for UrlClassifier

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement)

Description

[Gian-Carlo Pascutto [:gcp]]

C++ unit tests for some UrlClassifier parts exist but were disabled in bug 648911. 

Time to fix this.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Reenable C++ unit tests for UrlClassifier by converting to gtest

Comment 2

[François Marier [:francois]]

Comment on attachment 8693620 [details] [diff] [review]
Reenable C++ unit tests for UrlClassifier by converting to gtest

Review of attachment 8693620 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/url-classifier/tests/gtest/TestUrlClassifierUtils.cpp
@@ -272,5 @@
>    printf("CanonicalizeHostname on long string (%dms)\n",
>           PR_IntervalToMilliseconds(clockEnd - clockStart));
>  }
> -
> -void TestFragmentSet()

We don't need to test this anymore or is the test broken?

Comment 3

[Gian-Carlo Pascutto [:gcp]]

(In reply to François Marier [:francois] from comment #2)

> > -void TestFragmentSet()
> 
> We don't need to test this anymore or is the test broken?

The class that it's testing no longer seems to exist.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48e06b3d8ffb

Comment 5

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8000ef38139d5ea90a35c0ae13f4e3854920f08
Bug 1229051 - Reenable C++ unit tests for UrlClassifier by converting to gtest. r=francois

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8000ef38139