1229162 - "Priority Breakdown" report uses no_break filter, resulting in error

Status: RESOLVED FIXED

(Testopia :: Reports, defect)

Description

[u430950]

Since 'no_break' was removed in Bugzilla 5.0+, Priority Breakdown reports result in a error as it looks for the missing filter. This report needs to be modified so that it uses the 'nowrap' class, as changed in bug 880282

Comment 1

[u430950]

Attachment: patch.diff

Easy patch. Tested and works as expected.

Comment 2

[Frédéric Buclin]

Comment on attachment 8693785 [details] [diff] [review]
patch.diff

>           [% FOREACH p = priorities.keys.sort %]
>           <tr>
>-            <td style="border-right: 2px solid black; font-weight: bold; text-align: left;">[% p FILTER no_break %]</td>
>+            <td class="nowrap" style="border-right: 2px solid black; font-weight: bold; text-align: left;">[% p FILTER none %]</td>
>           </tr>
>           [% END %]
>         </table>

The patch is broken:

  patch: **** malformed patch at line 14: @@ -123,7 +123,7 @@


In my copy of this template, there are 9 <td> in this <tr> while there is only one in your patch.

Comment 3

[u430950]

Attachment: patch-v2.diff

My mistake. The previous patch had pieces of the Testopia consolidation in it that I incorrectly attempted to remove. Here is a new patch.

Comment 4

[Frédéric Buclin]

So which patch should be applied first? The other one first, right?

Comment 5

[u430950]

(In reply to Frédéric Buclin from comment #4)
> So which patch should be applied first? The other one first, right?

I reverted the file to trunk, so this one can be approved first.

Comment 6

[u430950]

On second thought, the other one would probably be best first, so that this one fixes that one filter area instead of the patch reverting.

Comment 7

[u430950]

Otherwise, I will need to write a new patch for tr_list_caseruns.

Comment 8

[Frédéric Buclin]

Err, I'm a bit confused. How is this patch related to this bug?? Isn't this patch about bug 1229135 instead?

Comment 9

[u430950]

This patch fixes the issue with priority breakdown reports resulting in an error. Ultimately, the problem in bug 1229135 is present on clickable links generated from this report, but that is a list problem rather than a report problem.

Comment 10

[Frédéric Buclin]

Comment on attachment 8693802 [details] [diff] [review]
patch-v2.diff

>-            <td style="border-right: 2px solid black; font-weight: bold; text-align: left;">[% p FILTER no_break %]</td>
>+            <td class="nowrap" style="border-right: 2px solid black; font-weight: bold; text-align: left;">[% p FILTER none %]</td>

We are in a HTML page, so it should be replaced by |FILTER html| instead, to prevent code injection. And the patch no longer applies cleanly due to the other checkin. Could you update it, please? :)

Comment 11

[u430950]

Attachment: patch-v3.diff

Switched FILTER to html and wrote patch against current trunk

Comment 12

[Frédéric Buclin]

Comment on attachment 8694362 [details] [diff] [review]
patch-v3.diff

Thanks! :) r=LpSolit

Comment 13

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/extensions/Testopia.git
   8703d68..97b81ca  master -> master