1229165 - [css-grid] min-height is not applied to grid container

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Javier Fernandez]

Attachment: bug-min-height.html

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.2.1
Build ID: 20150828090403

Steps to reproduce:

Loading the attached test case.


Actual results:

The grid container is 50px height, not honoring the min-height value of 100px.


Expected results:

The grid container should have honored the min-height restriction, hence being sized as 100px height.

Comment 1

[Mats Palmgren (inactive)]

Thanks for the bug report Javier!  I simply forgot to add this.

Comment 2

[Mats Palmgren (inactive)]

Attachment: [css-grid] Apply min/max-width/height properties on the grid container.

Comment 3

[Mats Palmgren (inactive)]

Attachment: reftests

Comment 4

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Comment on attachment 8694472 [details] [diff] [review]
[css-grid] Apply min/max-width/height properties on the grid container.

Review of attachment 8694472 [details] [diff] [review]:
-----------------------------------------------------------------

Commit message nit:
> Bug 1229165 - [css-grid] Apply min/max-width/height properties on the grid container.  r=dholbert

Technically, this patch only does this for the block-axis.

Maybe adjust prose to something like:
 "Apply min/max-width/height properties to clamp block size of auto-height grid containers"

r=me regardless

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81dcf2afd8f6
https://hg.mozilla.org/integration/mozilla-inbound/rev/6443e8cb46c3

Comment 6

[Mats Palmgren (inactive)]

> Technically, this patch only does this for the block-axis.

True.  I fixed the commit message as suggested.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/81dcf2afd8f6
https://hg.mozilla.org/mozilla-central/rev/6443e8cb46c3