122918 - Linux installer can crash/segfault if CRC checking fails

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Syd Logan]

Uncovered this while testing something else. Patch on the way.

Comment 1

[Syd Logan]

Attachment: patch to fix this

Test by setting MOZ_INSTALL_TEST_CRC=1 in your environment before running the
installer -- this will stress test CRC failures.

Comment 2

[Samir Gehani]

Comment on attachment 67389 [details] [diff] [review]
patch to fix this

>-	if ( retval == PR_TRUE && myConn->URL != (char *) NULL )
>+	if ( retval == PR_TRUE && myConn->URL != (char *) NULL ) {
>     free( myConn->URL );
>+    myConn->URL = (char *) NULL;
>+  }

Fix the tabbing problems, use TRUE instead of PR_TRUE and r=sgehani.

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 67389 [details] [diff] [review]
patch to fix this

>-	else if ( ( myConn->type != type || strcmp( URL, myConn->URL ) || force == PR_TRUE ) /* && gControls->state != ePaused */) {
>+	else if ( ( myConn->type != type || myConn->URL == (char *) NULL || strcmp( URL, myConn->URL ) || force == PR_TRUE ) /* && gControls->state != ePaused */) {

Wow, that's one heck of a long line

sr=dveditz

Comment 4

[Daniel Veditz [:dveditz]]

adding segfault to summary to attract dupes

Comment 5

[Daniel Veditz [:dveditz]]

*** Bug 123474 has been marked as a duplicate of this bug. ***

Comment 6

[Syd Logan]

*** Bug 97249 has been marked as a duplicate of this bug. ***

Comment 7

[Jeremy M. Dolan]

Todays linux build is crashing every install I attempt. Can someone confirm it's
a dupe of this? Where is the CRC failure? Bad ZIP archives on the server? Can
someone check this in? What's supposed to happen on these way-to-frequent CRC
failures?

Comment 8

[Syd Logan]

fixed

Comment 9

[K'Trina Medina]

Verified code fix