1229212 - <input type="number"> has a non-block-level flex item (the text control frame)

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Apply attachment 8692015 [details] [diff] [review] on top of current inbound tip:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/de171af8720b

 2. Compile a debug build.

 3. Load this URL in that debug build:
       data:text/html,<input type="number">

ACTUAL RESULTS: You'll trip one of the assertions in that patch.

EXPECTED RESULTS: No such assertion failures -- we should be able to assume that flex items are block-level.


BACKGROUND:
As I noted in bug 1176793 comment 20, we suppress flex-item-blockification inside of form controls, so that we don't accidentally blockify styles for the mandatory XUL junk that lives inside of e.g. <audio> just because someone happens to style it as "display:flex".  This suppression was added in bug 812822 and bug 844529, I believe.

So, <input type="number"> doesn't benefit from this auto-blockification. So, it should make sure its frames are block-level by hardcoding them as such, for any children that risk being anything other than block-level.

In this case, it's just its nsTextControlFrame (:-moz-number-text) which is incorrectly inline-level.  We can fix the assertion by giving that frame "display:block".

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v2

(Just tweaked patch with s/should/must/, RE flex items being blocks.)

Mats, I'm hoping this means your assertions in bug 1176793 can stay in.  Tagging you to review.

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8693853 [details] [diff] [review]
fix v2

OK, I'll leave the assertions in if the tests pass with this fix.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f647c855f10b

Comment 5

[Daniel Holbert [:dholbert]]

Looks like the tests do indeed pass with this fix -- hooray!  Successful try run (linux debug only):
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=d47a2f6401a4

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f647c855f10b