Closed Bug 1229270 Opened 4 years ago Closed 4 years ago

Provide UI in Send Format pane for new mailnews.sendformat.auto_downgrade preference

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(seamonkey2.42 affected, seamonkey2.43 fixed)

RESOLVED FIXED
seamonkey2.43
Tracking Status
seamonkey2.42 --- affected
seamonkey2.43 --- fixed

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

Details

Attachments

(3 files)

Bug 136502 has introduced a new preference setting to allow or deny the auto-detect downgrade to plain text when composing an HTML message. It also provided a checkbox in the Send Format dialog for Thunderbird, as can be seen in attachment 8690836 [details].

The aim for this bug is to add a corresponding checkbox to SeaMonkey's preferences. Options include Edit > Preferences > Mail & News > Send Format as the direct counterpart (which is a bit crowded already) or as an option in the Edit > Preferences > Mail & News > Composition preferences.

This also includes updating respective Help content.
> Options include Edit > Preferences > Mail & News > Send Format as the
> direct counterpart (which is a bit crowded already)

There appears to be quite a bit redundancy between the labels in that panel and the Help text, thus one solution to this might be to just remove those parts in favor of the new checkbox and potentially more space for the Domains boxes.
Note that bug 136502 also changed the scope of the auto-detect algorithm itself:

 - before that change, auto-detect wasn't applied when the address book card or a domain
   indicated that HTML is accepted, thus explicit listings overrode message content;

 - now, if the pref is set /and/ auto-detect decides that no sufficient formatting is
   present to warrant sending an HTML part, plain-text downgrade is performed /regardless/
   of any recipient or domain setting (thus, order of checks was reversed).

This makes me wonder if Edit > Preferences > Mail & News > Composition wouldn't be the more prominent place for this preference, in the "Defaults for HTML Messages" groupbox, given that it basically disables anything in the "Send Format" pane if auto-downgrade applies, thus being the default /before/ actually getting to any of the settings in that pane.

(Quoting Thomas D. from bug 136502 comment #168)
> This is the minimal fix indeed. Imho, still much too hidden, so mystery/surprise will
> remain for many users unless they dig themselves into 4th level send options.

We don't have the "Send Format" options as a subpane of "Composition" like Thunderbird, but adding the checkbox there among the other two groups will make it difficult to discover.
Flags: needinfo?(neil)
(In reply to rsx11m from comment #2)
> This makes me wonder if Edit > Preferences > Mail & News > Composition
> wouldn't be the more prominent place for this preference, in the "Defaults
> for HTML Messages" groupbox, given that it basically disables anything in
> the "Send Format" pane if auto-downgrade applies, thus being the default
> /before/ actually getting to any of the settings in that pane.
I'm not sure but I think that if you change any of those defaults then the message is no longer considered as convertible. Assuming that to be the case, I think the "Send Format" pane would be a better fit for the checkbox.
Flags: needinfo?(neil)
(In reply to neil@parkwaycc.co.uk from comment #3)
> I'm not sure but I think that if you change any of those defaults then the
> message is no longer considered as convertible.

Right, that was actually one of the recommended workarounds for bug 136502. There could be some logic to disable the checkbox on the "Composition" pane if any of the defaults is changed, but that's a bit messy and wouldn't work if the user changes the user-set color back to its default.

Thus, let's go with the "Send Format" pane. I'm posting some screenshots while working on the necessary updates to the Help content.
Attached image Screenshot (A)
This follows the Thunderbird approach to add the checkbox at the top, with a somewhat more explicit label. Given that SeaMonkey's preference pane is much larger than Thunderbird's, it looks a little bit lost there and may not convey the global nature of this option.

I've also shortened the labels for the radio buttons, to make them fit in a single line, especially with GTK3 on Linux having some larger spacing (at least on my machine, that is) and forcing them to wrap with a very short 2nd line for the 1 and 3 options. The label for the 2 option was very long, and at some time "formatted text (HTML)" was added, which is redundant as HTML is explained in the description already; I've changed "anyway" (which equally applies to the 3 option) to "only" to emphasize that no text part is sent with this option.

I've also removed the 2nd description below the radiogroup as it's explained in the Help content and doesn't also applies to the HTML/Plain Domain settings.
Attached image Screenshot (B)
In this variant, the checkbox is at the bottom of the pane and has a more descriptive label, stretching over two lines which were freed up by the removed override description. I like this better as it adds a perceived 3rd groupbox in that pane underneath the visually different listboxes for the domains, and its global context is much clearer.

Further minor change in the radiogroup labels for options 2 and 3, where "Send ... as HTML" vs. "Send ... in plain text" was used, I've changed the label for 3 to "as both plain text and HTML" for consistency.

Screenshots show Windows 7 with default theme and DirectWrite fonts enabled.
Summary: Provide UI for new mailnews.sendformat.auto_downgrade preference → Provide UI in Send Format pane for new mailnews.sendformat.auto_downgrade preference
This implements attachment 8696257 [details] and has several additions, clarifications, and a couple of reshuffled paragraphs in the Help content.
Attachment #8696346 - Flags: ui-review?(neil)
Attachment #8696346 - Flags: review?(iann_bugzilla)
Comment on attachment 8696346 [details] [diff] [review]
Proposed patch (B)

Seems ok to me r=me
Attachment #8696346 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8696346 [details] [diff] [review]
Proposed patch (B)

ui=r=me based on the screenshot.
Attachment #8696346 - Flags: ui-review?(neil) → ui-review+
Thanks for the reviews, push on comm-central please.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/e6015d5e4091
Target Milestone: --- → seamonkey2.43
How about SeaMonkey 2.42?
Keywords: checkin-needed
Comment on attachment 8696346 [details] [diff] [review]
Proposed patch (B)

Would be good in case we go with the 45 ESR branch, but a late-l10n case for that case. I'm thus nominating the patch if that's wanted and acceptable, otherwise we'll need to think about general comm-beta to comm-esr45 transitions and l10n handling for isolated cases once it's decided wether or not we go that route after 2.42.
Flags: needinfo?(iann_bugzilla)
Attachment #8696346 - Flags: approval-comm-aurora?
I remember Neil managed to steal a few strings from Firefox but I can't remember how he did it.
Using the Thunderbird string for comm-aurora sounds hackish, and there are likely conflicts or missing strings between Thunderbird's and SeaMonkey's DTD files, thus we can't just switch them (also, the Thunderbird version is much less informative than what we have in this patch).

I was hoping for IanN to comment during the holidays, also keeping in mind that this may not be the only UI modification we'd like to bring into SM releases if built from an ESR branch in an interim phase.
In most cases string changes in c-a (late l10n) are reserved to fixing bugs rather than adding features, so unless there is a way of pulling those specific strings from TB then probably cannot go into c-a.
See if Neil knows if it is possible to use a TB string for the new checkbox (other strings changes would probably not be needed).
Flags: needinfo?(iann_bugzilla) → needinfo?(neil)
I don't think it's possible because of l10n repacks; you'd have to ask KaiRo, Callek and/or ewong in case I'm mistaken.
Flags: needinfo?(neil)
Blocks: 1240738
Comment on attachment 8696346 [details] [diff] [review]
Proposed patch (B)

Cancelling the branch request now that 2.42 is on comm-beta already.
Let's revisit if and when future SM releases come from comm-esr45.
Attachment #8696346 - Flags: approval-comm-aurora?
Closing as FIXED given that the patch landed for 2.43 and thus nothing else to do here.
Watch bug 1240738 for any action if SM is released from a comm-esr45 in the future.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.