1229293 - Forbid HierarchicalStringList.__setattr__

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

We have multiple cases of things like this in the tree:
   RESOURCE_FILES.html = [
       'folder.png',
   ]

This totally overrides all type checking, starting with enforcing order on the list (see intl/unicharutil/tables/moz.build for example)

Comment 1

[Mike Hommey [:glandium]]

Actually, it's not so much of a problem, what *is* a problem is the lack of order enforcement on the StrictOrderingOnAppendList that HierarchicalStringList contain, and the fact that it's possible to overwrite a FOO.foo.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Enforce order when setting a HierarchicalStringList, and forbid reassignment

The current implementation of HierarchicalStringList allows the following:

   FOO.bar = [
       'foo',
       'bar',
   ]

while

   FOO.bar += [
       'foo',
       'bar',
   ]

would be invalid because of the StrictOrderingOnAppendList enforcement.

It also allows to overwrite the entire list with a subsequent

   FOO.bar = [
    'baz',
   ]

while we've explicitly forbidden such things for every other list.

While in the vicinity, fix HierarchicalStringList._get_export_variable to not
call the HierarchicalStringList constructor uselessly.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cceeacfe7d5f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cceeacfe7d5f