1229339 - Google's MSE compliance tests are now failing

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

Test such as test 14 are now failing.

http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html

It should display TestRunner:  checkApproxEq passed: Range end is (65.875011). 
yet the buffered range end is 60s only.

Comment 1

[Jean-Yves Avenard [:jya]]

git bisect gave me:
72b734ff9e405e2e43d1b64fa2ffa5b5c0d07eda is the first bad commit
commit 72b734ff9e405e2e43d1b64fa2ffa5b5c0d07eda
Author: Jean-Yves Avenard <[e-mail]>
Date:   Tue Nov 24 20:16:52 2015 +1100

    Bug 1227396: P7. Replace nsTArray<MediaByteRange> with dedicated MediaByteRangeSet object. r=cpearce

:040000 040000 2076b50bb764f4fdeb5e21129097d22396dbde13 c8146d1675095e27c730823bbe037d866295a146 M	dom
:040000 040000 b487fe86ad82b641f0c900e87681ba7adea0b184 3c8921b49c4bfb49b1cda7ca6621c0397704cafc M	media

which is http://hg.mozilla.org/mozilla-central/rev/c15c9f37f220e491e570fbca50edde924367b26e

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Partial revert of commit c15c9f37f.

Replacement of nsTArray<MediaByteRange> by MediaByteRangeSet in the MoofParser was incorrect.

Comment 3

[Jean-Yves Avenard [:jya]]

surprising MSE works as well as it does now with that bug !

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b8b0a674775

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b8b0a674775