Google's MSE compliance tests are now failing

RESOLVED FIXED in Firefox 45

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Unassigned)

Tracking

(Blocks: 1 bug, {regression})

Trunk
mozilla45
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Test such as test 14 are now failing.

http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html

It should display TestRunner:  checkApproxEq passed: Range end is (65.875011). 
yet the buffered range end is 60s only.
(Reporter)

Updated

2 years ago
Keywords: regression
(Reporter)

Comment 1

2 years ago
git bisect gave me:
72b734ff9e405e2e43d1b64fa2ffa5b5c0d07eda is the first bad commit
commit 72b734ff9e405e2e43d1b64fa2ffa5b5c0d07eda
Author: Jean-Yves Avenard <jyavenard@mozilla.com>
Date:   Tue Nov 24 20:16:52 2015 +1100

    Bug 1227396: P7. Replace nsTArray<MediaByteRange> with dedicated MediaByteRangeSet object. r=cpearce

:040000 040000 2076b50bb764f4fdeb5e21129097d22396dbde13 c8146d1675095e27c730823bbe037d866295a146 M	dom
:040000 040000 b487fe86ad82b641f0c900e87681ba7adea0b184 3c8921b49c4bfb49b1cda7ca6621c0397704cafc M	media

which is http://hg.mozilla.org/mozilla-central/rev/c15c9f37f220e491e570fbca50edde924367b26e
(Reporter)

Updated

2 years ago
Summary: Google's MSE compliance test are now failing → Google's MSE compliance tests are now failing
(Reporter)

Updated

2 years ago
Depends on: 1227396
(Reporter)

Comment 2

2 years ago
Created attachment 8694176 [details] [diff] [review]
Partial revert of commit c15c9f37f.

Replacement of nsTArray<MediaByteRange> by MediaByteRangeSet in the MoofParser was incorrect.
Attachment #8694176 - Flags: review?(cpearce)
(Reporter)

Comment 3

2 years ago
surprising MSE works as well as it does now with that bug !
Attachment #8694176 - Flags: review?(cpearce) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2b8b0a674775
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.