Closed Bug 1229339 Opened 9 years ago Closed 9 years ago

Google's MSE compliance tests are now failing

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: jya, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Partial revert of commit c15c9f37f.
2.20 KB, patch
cpearce
: review+
Details | Diff | Splinter Review 
Test such as test 14 are now failing.

http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html

It should display TestRunner:  checkApproxEq passed: Range end is (65.875011). 
yet the buffered range end is 60s only.
Keywords: regression
git bisect gave me:
72b734ff9e405e2e43d1b64fa2ffa5b5c0d07eda is the first bad commit
commit 72b734ff9e405e2e43d1b64fa2ffa5b5c0d07eda
Author: Jean-Yves Avenard <jyavenard@mozilla.com>
Date:   Tue Nov 24 20:16:52 2015 +1100

    Bug 1227396: P7. Replace nsTArray<MediaByteRange> with dedicated MediaByteRangeSet object. r=cpearce

:040000 040000 2076b50bb764f4fdeb5e21129097d22396dbde13 c8146d1675095e27c730823bbe037d866295a146 M	dom
:040000 040000 b487fe86ad82b641f0c900e87681ba7adea0b184 3c8921b49c4bfb49b1cda7ca6621c0397704cafc M	media

which is http://hg.mozilla.org/mozilla-central/rev/c15c9f37f220e491e570fbca50edde924367b26e
Summary: Google's MSE compliance test are now failing → Google's MSE compliance tests are now failing
Depends on: 1227396
Replacement of nsTArray<MediaByteRange> by MediaByteRangeSet in the MoofParser was incorrect.
Attachment #8694176 - Flags: review?(cpearce)
surprising MSE works as well as it does now with that bug !
Attachment #8694176 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/2b8b0a674775
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: