1229372 - [Messages][NG] Update tools/update_nga_libs.sh script to work with new fxos-components repository

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

gaia-components repository has been renamed to fxos-components [1], so we should update our script to point to the new address + bridge plugins folder has been moved to a top level directory [2] that we should respect as well.

[1] https://groups.google.com/d/msg/mozilla.dev.fxos/hrlcr64eMQo/C7_KpDbCAgAJ
[2] https://github.com/fxos-components/bridge/commit/5838b485939c4c40b23a15b6e5bf05dcbd109b79

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1229372-update-libs > mozilla-b2g:master

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8694256 [details] [review]
[gaia] azasypkin:bug-1229372-update-libs > mozilla-b2g:master

Hey Julien,

What do you think?

Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8694256 [details] [review]
[gaia] azasypkin:bug-1229372-update-libs > mozilla-b2g:master

r=me

I'll assume you manually tested the paths that use the bridge :) Also maybe run the script once again and test this new version...

Comment 4

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Comment on attachment 8694256 [details] [review]
> [gaia] azasypkin:bug-1229372-update-libs > mozilla-b2g:master
> 
> r=me
> 
> I'll assume you manually tested the paths that use the bridge :) Also maybe
> run the script once again and test this new version...

Yeah, manually and we have integration tests for all major places where bridge is used, now using the latest Bridge version :)

Master: https://github.com/mozilla-b2g/gaia/commit/121c1cad399d0d7f6b8f22763730ea3a8a21344c