Include wptserve in common.tests.zip

RESOLVED FIXED in Firefox 45

Status

()

Core
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: maja_zf, Assigned: maja_zf)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

In order to use the in-tree copy of wptserve for Marionette-based tests, we need to include wptserve in common.tests.zip.
I have a patch that results in wptserve being in common.tests.zip under /tools/wptserve (copied from testing/web-platform/tests/tools/wptserve/). This try run [1] looks good, but I'm going to do some more testing today before I submit the patch. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bf9efddba7a&selectedJob=14306851
Created attachment 8694416 [details]
MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

Bug 1229467 - Include wptserve in common.tests.zip; r?gps
Attachment #8694416 - Flags: review?(gps)

Comment 4

2 years ago
Comment on attachment 8694416 [details]
MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

https://reviewboard.mozilla.org/r/26741/#review24199

::: testing/testsuite-targets.mk:476
(Diff revision 1)
> +	@(cd $(topsrcdir)/testing/web-platform/tests/tools/wptserve && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/tools/wptserve && tar -xf -)

This isn't how we do things any more. Instead, ddit the dict at the top of `python/mozbuild/mozbuild/action/test_archive.py` instead to define which files are placed in which test archives. You shouldn't need to change this file at all.
Attachment #8694416 - Flags: review?(gps)
Attachment #8694416 - Flags: review?(gps)
Comment on attachment 8694416 [details]
MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26741/diff/1-2/

Comment 6

2 years ago
Comment on attachment 8694416 [details]
MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

https://reviewboard.mozilla.org/r/26741/#review24535
Attachment #8694416 - Flags: review?(gps) → review+

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/21a130c2ba15
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.