1229467 - Include wptserve in common.tests.zip

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

In order to use the in-tree copy of wptserve for Marionette-based tests, we need to include wptserve in common.tests.zip.

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I have a patch that results in wptserve being in common.tests.zip under /tools/wptserve (copied from testing/web-platform/tests/tools/wptserve/). This try run [1] looks good, but I'm going to do some more testing today before I submit the patch. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bf9efddba7a&selectedJob=14306851

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

Bug 1229467 - Include wptserve in common.tests.zip; r?gps

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76fe74c03c3f

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8694416 [details]
MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

https://reviewboard.mozilla.org/r/26741/#review24199

::: testing/testsuite-targets.mk:476
(Diff revision 1)
> +	@(cd $(topsrcdir)/testing/web-platform/tests/tools/wptserve && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/tools/wptserve && tar -xf -)

This isn't how we do things any more. Instead, ddit the dict at the top of `python/mozbuild/mozbuild/action/test_archive.py` instead to define which files are placed in which test archives. You shouldn't need to change this file at all.

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8694416 [details]
MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26741/diff/1-2/

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8694416 [details]
MozReview Request: Bug 1229467 - Include wptserve in common.tests.zip; r?gps

https://reviewboard.mozilla.org/r/26741/#review24535

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21a130c2ba15

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21a130c2ba15