1229481 - [webvr] Implement Reftest support for WebVR functionality

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1229481 - Part 1: Move VR mochitest to its subfolder;

Review commit: https://reviewboard.mozilla.org/r/137054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137054/

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1229481 - Part 2: Remove assert_true be more flexible in VRSimluationDisplay.js

Review commit: https://reviewboard.mozilla.org/r/137056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137056/

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1229481 - Part 2: Add draw rect reftest for WebVR;

Review commit: https://reviewboard.mozilla.org/r/137058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137058/

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8865386 [details]
Bug 1229481 - Part 2: Add draw rect reftest for WebVR;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137058/diff/1-2/

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8865384 [details]
Bug 1229481 - Part 1: Move VR mochitest to its subfolder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137054/diff/1-2/

Comment 6

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8865386 [details]
Bug 1229481 - Part 2: Add draw rect reftest for WebVR;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137058/diff/2-3/

Comment 7

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #6)
> Comment on attachment 8865386 [details]
> Bug 1229481 - Part 2: Add draw rect reftest for WebVR;
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/137058/diff/2-3/

The VRSimulationDriver.js can't be included from mochitest/ because our reftest toolchain can not get it when we run it globally. So, I copy it mochitest/ Moreover, I notice draw_rect.html will wait lots of time for finishing when running in reftest Nightly Debug, but running it without reftest, it is good. I wanna skip it for now and keep investigating how to solve it in reftest Nightly Debug environment.

Try looks good,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fc01cfdc0d2f7972843c9e79a34b11b4d51a78e

Comment 8

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #7)

> Try looks good,
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=7fc01cfdc0d2f7972843c9e79a34b11b4d51a78e

BTW, the try result for VR is at (R) and (R-e10s).

Comment 9

[:kip (Kearwood Gilbert)]

Comment on attachment 8865384 [details]
Bug 1229481 - Part 1: Move VR mochitest to its subfolder;

https://reviewboard.mozilla.org/r/137054/#review148062

Looks good, thanks!

Comment 10

[:kip (Kearwood Gilbert)]

Comment on attachment 8865386 [details]
Bug 1229481 - Part 2: Add draw rect reftest for WebVR;

https://reviewboard.mozilla.org/r/137058/#review148100

This looks good, except for the readability of reftest.list.

r=me if you can move the image from the base64 data to a file.

::: dom/vr/test/reftest/reftest.list:7
(Diff revision 3)
> +default-preferences pref(dom.vr.puppet.enabled,true) pref(dom.vr.test.enabled,true) pref(dom.vr.require-gesture,false) pref(dom.vr.puppet.submitframe,1)
> +
> +# VR SubmitFrame is only implemented for D3D11 now.
> +# We need to continue to investigate why these reftests can be run well in local,
> +# but will be suspended until terminating on reftest debug build.
> +skip-if(!winWidget||!layersGPUAccelerated||isDebugBuild) == draw_rect.html wrapper.html?data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAQAAAAEACAYAAABccqhmAAAGmklEQVR4nO3RsQ0AMAzDsPz/dHsGBwuEdiO5e0lm8QFJHD4gicMHJHH4gCQOH5DE4QOSOHxAEocPSOLwAUkcPiCJwwckcfiAJA4fkMThA5I4fEAShw9I4vABSRw+IInDByRx+IAkDh+QxOEDkjh8QBKHD0ji8AFJHD4gicMHJHH4gCQOH5DE4QOSOHxAEocPSOLwAUkcPiCJwwckcfiAJA4fkMThA5I4fEAShw9I4vABSRw+IInDByRx+IAkDh+QxOEDkjh8QBKHD0ji8AFJHD4gicMHJHH4gCQOH5DE4QOSOHxAEocPSOLwAUkcPiCJwwckcfiAJA4fkMThA5I4fEASRw94t906fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j9AD9AN06fX8dpwfoB+jW6fvrOD1AP0C3Tt9fx+kB+gG6dfr+Ok4P0A/QrdP313F6gH6Abp2+v47TA/QDdOv0/XWcHqAfoFun76/j+IAkDh+QxOEDkjh8QBKHD0ji8AFJHD4gicMHJHH4gCQOH5DE4QOSOHxAEocPSOLwAUkcPiCJwwckcfiAJA4fkMThA5I4fEAShw9I4vABSRw+IInDByRx+IAkDh+QxOEDkjh8QBKHD0ji8AFJHD4gicMHJHH4gCQOH5DE4QOSOHxAEocPSOLwAUkcPiCJwwckcfiAJA4fkMThA5I4fEAShw9I4vABSRw+IInDByRx+IAkDh+QxOEDkjh8QBKHD0ji8AFJHD4gicMHJHH4gCQOH5DE4QOSOHxAEocPSOLwAUkcPiCJwwckYT4olR3j8YEJmwAAAABJRU5ErkJggg==

This could become difficult to read once more tests are added.

Perhaps we could move the image to a file rather than passing it as base64 data?

Comment 11

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8865386 [details]
Bug 1229481 - Part 2: Add draw rect reftest for WebVR;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137058/diff/3-4/

Comment 12

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8865386 [details]
Bug 1229481 - Part 2: Add draw rect reftest for WebVR;

https://reviewboard.mozilla.org/r/137058/#review148100

> This could become difficult to read once more tests are added.
> 
> Perhaps we could move the image to a file rather than passing it as base64 data?

Good suggestion. Thank!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c13bf6be43e
Part 1: Move VR mochitest to its subfolder; r=kip
https://hg.mozilla.org/integration/autoland/rev/bce41e33bffd
Part 2: Add draw rect reftest for WebVR; r=kip

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c13bf6be43e
https://hg.mozilla.org/mozilla-central/rev/bce41e33bffd