1229495 - Build error: 'no preprocessor directives found' in 'suite/locales/en-US/searchplugins/duckduckgo.xml'

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Stefan Sitter [:ssitter]]

Originally reported in Bug 1229419 Comment 3:

> ...'c:/seamonkey/comm-central/suite/locales/en-US/searchplugins/duckduckgo.xml' -o '../../dist/bin/searchplugins/duckduckgo.xml'
> rm -f '../../dist/bin/searchplugins/wikipedia.xml'
> Traceback (most recent call last):
>   File "c:\mozilla-build\python\Lib\runpy.py", line 162, in _run_module_as_main
>     "__main__", fname, loader, pkg_name)
>   File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
>     exec code in run_globals
>   File "c:\seamonkey\comm-central\mozilla\python\mozbuild\mozbuild\action\preprocessor.py", line 18, in <module>
>     main(sys.argv[1:])
>   File "c:\seamonkey\comm-central\mozilla\python\mozbuild\mozbuild\action\preprocessor.py", line 14, in main
>     pp.handleCommandLine(args, True)
>   File "c:\seamonkey\comm-central\mozilla\python\mozbuild\mozbuild\preprocessor.py", line 483, in handleCommandLine
>     self.processFile(input=input, output=out)
>   File "c:\seamonkey\comm-central\mozilla\python\mozbuild\mozbuild\preprocessor.py", line 388, in processFile
>     self.failUnused(input.name)
>   File "c:\seamonkey\comm-central\mozilla\python\mozbuild\mozbuild\preprocessor.py", line 332, in failUnused
>     raise Preprocessor.Error(fake, msg, None)
> mozbuild.preprocessor.Error: ('c:/seamonkey/comm-central/suite/locales/en-US/searchplugins/duckduckgo.xml', None, 'no preprocessor directives found', None)
> c:/seamonkey/comm-central/mozilla/config/rules.mk:1460: recipe for target '../../dist/bin/searchplugins/duckduckgo.xml' failed
> mozmake[4]: *** [../../dist/bin/searchplugins/duckduckgo.xml] Error 1
> mozmake[4]: *** Deleting file '../../dist/bin/searchplugins/duckduckgo.xml'
> mozmake[4]: *** Waiting for unfinished jobs....

This looks like fallout from Bug 1228467 - Make the preprocessor error out for "no preprocessing directives".

If I investigated it correct the files are read from searchplugins/list.txt <http://mxr.mozilla.org/comm-central/source/suite/locales/Makefile.in#60> added to PP_TARGETS in http://mxr.mozilla.org/comm-central/source/suite/locales/Makefile.in#65

Maybe this can be switched to a target without preprocessing, after ensuring that none of the existing localizations uses preprocessing in the searchplugins files.

Comment 1

[Tony Mechelynck [:tonymec]]

So this is why there were no nightlies on December 1! The fact that there were no nightlies even on platforms which had them the day before (i.e. L32, L64 and Mac) makes me think that either there is yet another blocker born on the same day, or this is a platform-agnostic bug.

FTR: From comment #0 it can be seen that the bug was seen on Windows; which particular Windows architecture is less evident.

Comment 2

[Tony Mechelynck [:tonymec]]

I'm setting the dependency on the assumption that ssitter guessed it right in comment #0. Feel free to set if differently if another culprit is found.

Comment 3

[Stefan Sitter [:ssitter]]

A patch to silence the SeaMonkey build error was added to Bug 1229419 instead of adding it here.

Comment 4

[Philip Chee]

Attachment: Silence complaints about missing preprocessor directives in search plugins. r=IanN

Firefox and Thunderbird have had this bit for ages, but somehow we never bothered to turn off the warnings until now when glandium made preprocessor warnings errors instead.

(I'll file separate bugs for the DOM Inspector and Chatzilla.

Comment 5

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/66bd106eb4f9

Comment 6

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/66bd106eb4f9

Comment 7

[Philip Chee]

Comment on attachment 8694921 [details] [diff] [review]
Silence complaints about missing preprocessor directives in search plugins. r=IanN

Carrying forward r+ from Bug 1229419