1229625 - Sync prefs pane let's you change the device name to an empty string but doesn't reflect that a default will then be used instead.

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

STR:
* In sync prefs, change the device name to an empty string. It remains an empty string after clicking the change button.
* Close Sync prefs and re-open - the name now has a default value.

Either the prefs pane should reject an empty name, or the default value for the device name should be shown immediately after changing it to an empty string. The latter is much easier - we just re-get the device name after setting it.

Comment 1

[Lina Butler [:lina]]

Attachment: MozReview Request: Bug 1229625 - Use the default device name as a placeholder in Sync prefs. r?markh

Review commit: https://reviewboard.mozilla.org/r/30953/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30953/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8708053 [details]
MozReview Request: Bug 1229625 - Use the default device name as a placeholder in Sync prefs. r?markh

https://reviewboard.mozilla.org/r/30953/#review28579

LGTM

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e73782d7fc9b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e73782d7fc9b

Comment 5

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> INCOMPLETE

Comments:
Test is working

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
1. Ask for device name if left empty
2. Reset to default device name if left empty.


Actual Results: 
It does not ask for input even if empty string for device name
2nd case is working.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mayur Patil from comment #5)
> [bugday-20160323]
> 
> Status: RESOLVED,FIXED -> INCOMPLETE
> ...
> It does not ask for input even if empty string for device name

My testing shows a placeholder with the default name when you clear the text, and that default name is used. The "INCOMPLETE" status makes me wonder if you think this bug needs a followup to work as expected?

Comment 7

[Mayur Patil]

My intention behind INCOMPLETE status is that:

One test is complete while other one is not.

The default name comes after the field gets cleared - done.

Pref pane reject the empty string - not done.

I would like to modify it to "Once user device name is saved, it should deny empty string without showing default name" 

Lets see if this could work it will also help to reduce devices with same name I think.

What do you think?

Comment 8

[Mark Hammond [:markh] [:mhammond]]

(In reply to Mayur Patil from comment #7)
> My intention behind INCOMPLETE status is that:
> 
> One test is complete while other one is not.
> 
> The default name comes after the field gets cleared - done.
> 
> Pref pane reject the empty string - not done.
> 
> I would like to modify it to "Once user device name is saved, it should deny
> empty string without showing default name" 

We decided that "rejecting" is bad UX - it presumably means we must show a modal alert dialog with an error message, then force the user to enter some name. The alternative, and what we have implemented, is to treat the empty string as meaning the default device name should be used - and that the UI clearly shows this (ie, it is impossible to see the device name with an empty string - as soon as it becomes empty, the default device name is shown as a placeholder).

Personally I think this is much better, but I guess we should ask UX.

Ryan,
  This conversation is about what happens when the user clears the "device name" field - currently in that case we show "placeholder" text with the default device name, and that default name is used if the user presses "Save" while that placeholder is shown. Mayur is advocating that we should actively reject an empty string forcing the user to enter something in that field, and presumably showing some error message when we reject it. Do you think the current behaviour should be changed to behave more like that?

Comment 9

[Ryan Feeley [:rfeeley]]

I think it's great the way it is (and as you describe it Mark). The placeholder copy is exactly what should be saved if the user clears the field.