Closed
Bug 1229648
Opened 9 years ago
Closed 9 years ago
Eliminate nulls in GetSubfolders calls
Categories
(MailNews Core :: Backend, defect)
Tracking
(thunderbird44 wontfix, thunderbird45 fixed)
RESOLVED
FIXED
Thunderbird 45.0
People
(Reporter: rkent, Assigned: rkent)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
5.37 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
Null out parameters cause crashes when passed through XPCOM. Eliminate these calls in mailnews core (needed by JsAccount).
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8694573 [details] [diff] [review] Replace nullptr with dummyPtr Review of attachment 8694573 [details] [diff] [review]: ----------------------------------------------------------------- rs+
Attachment #8694573 -
Flags: review?(Pidgeot18) → review+
|
||
Comment 3•9 years ago
|
||
Just as a quick drive-by nit, I'd probably prefer calling the dummy variable "unused", since that makes it clearer to me that it's just an artifact of the API rather than a dummy in some other sense of the word (e.g. an nsDummyMsgHeader[1]). [1] http://mxr.mozilla.org/comm-central/source/mail/base/content/msgHdrViewOverlay.js#2731
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/4de2764e81a0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-thunderbird44:
--- → wontfix
status-thunderbird45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in
before you can comment on or make changes to this bug.
Description
•