Closed Bug 1229648 Opened 6 years ago Closed 5 years ago

Eliminate nulls in GetSubfolders calls

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(thunderbird44 wontfix, thunderbird45 fixed)

RESOLVED FIXED
Thunderbird 45.0
Tracking Status
thunderbird44 --- wontfix
thunderbird45 --- fixed

People

(Reporter: rkent, Assigned: rkent)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Null out parameters cause crashes when passed through XPCOM. Eliminate these calls in mailnews core (needed by JsAccount).
Assignee: nobody → rkent
Status: NEW → ASSIGNED
Attachment #8694573 - Flags: review?(Pidgeot18)
Comment on attachment 8694573 [details] [diff] [review]
Replace nullptr with dummyPtr

Review of attachment 8694573 [details] [diff] [review]:
-----------------------------------------------------------------

rs+
Attachment #8694573 - Flags: review?(Pidgeot18) → review+
Just as a quick drive-by nit, I'd probably prefer calling the dummy variable "unused", since that makes it clearer to me that it's just an artifact of the API rather than a dummy in some other sense of the word (e.g. an nsDummyMsgHeader[1]).

[1] http://mxr.mozilla.org/comm-central/source/mail/base/content/msgHdrViewOverlay.js#2731
https://hg.mozilla.org/comm-central/rev/4de2764e81a0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
You need to log in before you can comment on or make changes to this bug.