122970 - Blame for warnings doesn't cover non-SeaMonkeyAll

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox, defect)

Description

[Bradley Baetz (:bbaetz)]

If you go to the url, which is the warning log from Brad, there some unblamed
warnings. Looking at the supplied filenames, it looks like the warnings script
only parses stuff from SeaMonkeyAll. security, gfx2, and accessible are missing,
at least.

For bonus points, it should blame from the correct branch.

Comment 1

[Bradley Baetz (:bbaetz)]

*** Bug 122971 has been marked as a duplicate of this bug. ***

Comment 2

[Chris McAfee]

the file that does this is mozilla/webtools/tinderbox/warnings.pl,
my first read of this is that it looks at @cvs_modules for the SeaMonkey tree,
on lounge & SeaMonkey this is
  'mozilla/security' 'SECURITY_CLIENT_BRANCH'
  'mozilla/nsprpub'  'NSPRPUB_CLIENT_BRANCH'
  'SeaMonkeyAll'     'HEAD'

Maybe this is working, what happens for security warnings?

The server stores the branch in the local treedata.pl file, so any
client.mk changes to the branch won't show up here w/o a manual update.
Not sure how this mechanism got here, adding cls who might know.

Comment 3

[Bradley Baetz (:bbaetz)]

So that file just needs to be updated, then?

The security stuff is wrong - it needs NSS_CLIENT_TAG for nss, and HEAD for the
other security stuff. We should add gfx2 and accessible, and imglib2 into there,
too. NSPR tag should be NSPRPUB_PRE_4_2_CLIENT_BRANCH

The ldap stuff needs to be added, too.

Comment 4

[timeless]

should we modify the tinderclient so that it reports cvs the tags it used so 
that tinderserver doesn't need to hardcode them?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Tinderbox isn't maintained anymore. Closing.