Closed
Bug 1229739
Opened 9 years ago
Closed 9 years ago
Text shadow of emphasis marks should use the color of the shadow
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 3 obsolete files)
Currently the color from text-emphasis-color is used as well for the shadow of emphasis marks, which is wrong.
Attachment #8694722 -
Attachment is obsolete: true
Attachment #8694723 -
Attachment is obsolete: true
Attachment #8694724 -
Attachment is obsolete: true
|
Assignee | |
Comment 5•9 years ago
|
||
Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow.
Attachment #8695100 -
Flags: review?(jfkthame)
|
|
Assignee | |
Comment 6•9 years ago
|
||
No reftest is added because, due to bug 1229979 and bug 1229982, currently there aren't many things we can test for combination of text decoration/emphasis and text shadow. I'd prefer to see we get those bugs fixed before submitting new tests. (Alternatively we can add some failing reftests now and flip them later.)
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8695100 [details] MozReview Request: Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow. https://reviewboard.mozilla.org/r/27007/#review24435
Attachment #8695100 -
Flags: review?(jfkthame) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3ab483587f5d49cff06a2691d7e46735594ee67 Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow. r=jfkthame
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → quanxunzhen
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d3ab483587f5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•