Text shadow of emphasis marks should use the color of the shadow

RESOLVED FIXED in Firefox 45

Status

()

Core
Layout: Text
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Blocks: 1 bug)

Trunk
mozilla45
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 3 obsolete attachments)

Currently the color from text-emphasis-color is used as well for the shadow of emphasis marks, which is wrong.

Comment 1

2 years ago
Created attachment 8694722 [details]
testcase.html

Comment 2

2 years ago
Created attachment 8694723 [details]
testcase.html
Attachment #8694722 - Attachment is obsolete: true

Comment 3

2 years ago
Created attachment 8694724 [details]
testcase.html
Attachment #8694723 - Attachment is obsolete: true

Comment 4

2 years ago
Created attachment 8694726 [details]
testcase.html
Attachment #8694724 - Attachment is obsolete: true
Created attachment 8695100 [details]
MozReview Request: Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow.

Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow.
Attachment #8695100 - Flags: review?(jfkthame)
No reftest is added because, due to bug 1229979 and bug 1229982, currently there aren't many things we can test for combination of text decoration/emphasis and text shadow. I'd prefer to see we get those bugs fixed before submitting new tests. (Alternatively we can add some failing reftests now and flip them later.)
Comment on attachment 8695100 [details]
MozReview Request: Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow.

https://reviewboard.mozilla.org/r/27007/#review24435
Attachment #8695100 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3ab483587f5d49cff06a2691d7e46735594ee67
Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow. r=jfkthame
Assignee: nobody → quanxunzhen

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d3ab483587f5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.