Closed Bug 1229739 Opened 4 years ago Closed 4 years ago

Text shadow of emphasis marks should use the color of the shadow

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 3 obsolete files)

Currently the color from text-emphasis-color is used as well for the shadow of emphasis marks, which is wrong.
Attached file testcase.html (obsolete) —
Attached file testcase.html (obsolete) —
Attachment #8694722 - Attachment is obsolete: true
Attached file testcase.html (obsolete) —
Attachment #8694723 - Attachment is obsolete: true
Attached file testcase.html
Attachment #8694724 - Attachment is obsolete: true
Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow.
Attachment #8695100 - Flags: review?(jfkthame)
No reftest is added because, due to bug 1229979 and bug 1229982, currently there aren't many things we can test for combination of text decoration/emphasis and text shadow. I'd prefer to see we get those bugs fixed before submitting new tests. (Alternatively we can add some failing reftests now and flip them later.)
Comment on attachment 8695100 [details]
MozReview Request: Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow.

https://reviewboard.mozilla.org/r/27007/#review24435
Attachment #8695100 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3ab483587f5d49cff06a2691d7e46735594ee67
Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow. r=jfkthame
Assignee: nobody → quanxunzhen
https://hg.mozilla.org/mozilla-central/rev/d3ab483587f5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.