1229826 - Should not use string "fill me" for fields with unknown values

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[William Lachance (:wlach)]

I guess the idea was that the "fill me" string would be incentive to provide values for these fields?

Well the jury is out: after more than a year of treeherder, no one cares enough to fill these fields in many cases. Let's just leave them blank where unspecified. We can save some space and bandwidth that way.

Comment 1

[William Lachance (:wlach)]

Attachment: PR

I think this will make you happy. :)

This won't fix the existing database, but that's just a quick database update.

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f1c6392ac1570b38b5938a8eba66b943b68a5725
Bug 1229826 - Use "" instead of "fill me" for unspec'd fields

Comment 3

[William Lachance (:wlach)]

I updated the existing jobtype strings on stage and prod to replace "fill me" with "". The savings were pretty negligible (.5k on compressed, 40k uncompressed on stage), but whatever. :)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Did more "fill me"s sneak back in? I see at least one on https://treeherder.mozilla.org/#/jobs?repo=try&fromchange=ea9143b556042fc0f2000720b03a5a10d09df6d4&tochange=ea9143b556042fc0f2000720b03a5a10d09df6d4&filter-searchStr=aab1db13e98e4c798675b9eb75e1b8bcf6142dba

Comment 5

[William Lachance (:wlach)]

"git grep" shows no "fill me" strings in the treeherder repository, aside from the initial migration.

It's possible taskcluster is submitting data with "fill me" in it.