1229838 - Support for apple-touch-icon-precomposed to trigger mozbrowsericonchange

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Sam Foster [:sfoster] (he/him)]

AFAICT this looks like it just needs a simple change to https://dxr.mozilla.org/mozilla-central/source/dom/browser-element/BrowserElementChildPreload.js#597 and the associated mochitest to recognize the rel="apple-touch-icon-precomposed" value as a change we want to announce as a mozbrowsericonchange event

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: rel=apple-touch-icon-precomposed should fire mozbrowsericonchange

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: rel=apple-touch-icon-precomposed should fire mozbrowsericonchange

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8695641 [details] [diff] [review]
rel=apple-touch-icon-precomposed should fire mozbrowsericonchange

This fixes the symptoms of bug 1217095 for me - github and others are using the 'apple-touch-icon-precomposed' in favor of the apple-touch-icon link relation. 

We may also need a corresponding gaia change to update the condition that triggers the warning added in https://github.com/mozilla-b2g/gaia/commit/f3a33a528d194dc631ecc892ba24ea152ed087b4

Comment 5

[Sam Foster [:sfoster] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27b46d0716eb

Comment 6

[Sam Foster [:sfoster] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41dc498b776c

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Sam Foster [:sfoster] from comment #6)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=41dc498b776c

Still some orange in there, what do you think Fabrice? Sorry I have no context on these tests so I'm relying on someone else to tell me if I caused a problem here or not.

Comment 8

[[:fabrice] Fabrice Desré]

I can't see any reasons for these failures to be caused by your patch. ship it!

Comment 9

[Sam Foster [:sfoster] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e8934c580ec5c0c7fcc60543cfcda621cfef87b
Bug 1229838 - rel=apple-touch-icon-precomposed should fire mozbrowsericonchange. r=fabrice

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e8934c580ec