1229858 - Support eslint in XBL files

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Dave Townsend [:mossop]]

We should be able to create (or find) an eslint plugin that preprocesses XBL files into lintable JS

Comment 1

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1229858: Add a preprocessor to convert XBL into JavaScript blocks for eslint. r?miker

Bug 1229858: Add a preprocessor to convert XBL into JavaScript blocks for eslint. r?miker

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8695038 [details]
MozReview Request: Bug 1229858: Add a preprocessor to convert XBL into JavaScript blocks for eslint. r?miker

https://reviewboard.mozilla.org/r/26965/#review24715

Awesome work, easy r+

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6c9319ab4430

Comment 4

[:Gijs (he/him)]

This is breaking for me:

gkruitbosch-16516:fx-team gkruitbosch$ ./mach eslint browser/base/content/
 0:00.22 Running /usr/local/bin/eslint
 0:00.22 /usr/local/bin/eslint --ext [.js,.jsm,.jsx,.xml] browser/base/content/
/Users/gkruitbosch/dev/fx-team/testing/eslint-plugin-mozilla/lib/processors/xbl-bindings.js:12
const NS_XBL = "http://www.mozilla.org/xbl";
^^^^^
SyntaxError: Use of const in strict mode.
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/gkruitbosch/dev/fx-team/testing/eslint-plugin-mozilla/lib/index.js:17:13)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)

Comment 5

[Dave Townsend [:mossop]]

(In reply to :Gijs Kruitbosch from comment #4)
> This is breaking for me:

Which version of node are you running?

Comment 6

[Dave Townsend [:mossop]]

So it seems like this code uses ES6 features only available in node >5. DO we have a policy on what node version we should support?

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6c9319ab4430

Comment 8

[Dave Townsend [:mossop]]

Turns out that the Gaia developers use the LTS version of node, 4.2.3 so we should probably standardise on that. Bug 1231867 will fix this code to work there.