1229932 - [Skia-update branch] SkRect.h:745: failed assertion "!r.isEmpty()"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Using the Mac build from https://treeherder.mozilla.org/#/jobs?repo=try&revision=91dc4f334fc5

(This does NOT reproduce on mozilla-central because bug 1082598 has not landed yet.)

gfx/skia/skia/include/core/SkRect.h:745: failed assertion "!r.isEmpty()"

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: check that offsets to canvas fillText() are finite

The canvas spec allows infs ("unrestricted float") to be passed in to fillText(), though it does not specify what should be done with them.

Given that other places in the spec where float values are restricted to finite values, infs cause drawing to be ignored, and an inf offset can be reasonably interpreted here as "offset so far as to not be possibly visible", it seems best to just bail out of rendering text with infinite offsets.

Since Skia can't handle this downstream and it probably not being healthy for the other backends either to make them handle infs, this seems better handled in canvas itself.

Comment 3

[Lee Salzman [:lsalzman]]

Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ebf8407b872

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aaa92eab9fe4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aaa92eab9fe4