1230038 - Eventually remove old push crypto

Status: NEW

(Core :: DOM: Push Subscriptions, task, P3)

Description

[Martin Thomson [:mt:]]

Bug 1225968 added new and improved push crypto.  The old crypto is still in place for compatibility reasons, but can be eventually be removed.  This bug tracks that.

Comment 1

[Ryan Kelly [:rfkelly]]

:jrconlin recently shared a graph here with the line for "aesgcm128 traffic seen by the push server" sitting comfortably at zero. I believe this bug is now actionable.

Comment 2

[Ryan Kelly [:rfkelly]]

Since I've been in "remove unnecessary stuff from push crypto libraries" mode recently, I thought I'd have a quick go at removing this. Removing the old crypto code seems straightforward enough, and is a nice little cleanup. The problem is tests: we have a small number of tests that currently hard-code test data using aesgcm128 format. Before we can remove support for it, we'll need to re-generate appropriate test data using a newer encoding. Specifically:

• The helpers in dom/push/test/webpush.js
• The fixtures in testing/xpcshell/moz-http2/moz-http2.js
• Some fixtures in dom/push/test/xpcshell/test_notification_data.js

Unfortunately, tracking down what the underlying raw data should be and figuring out how to re-encrypt it with a newer scheme would take me far beyond the little timebox I set myself for this diversion. I'd be happy to push my work-in-progress patch if anyone felt like diving in, but I won't push it here by default because it doesn't seem worth having a half-done patch lying around indefinitely.