123015 - QuickSearch: Clear a no-match search, select msg doesn't load body

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using feb01 commercial trunk build

After you clear a search which found no matches, when you select a message in
the thread pane the body won't load.  Once you focus the folder pane or select
another folder and return, selectin messages will now load content.

1.  Open a mail folder or newsgroup, search bar is shown.
2.  Type something in the search bar which will not match any subject or sender
in the folder view.
3.  Empty search view appears, click Clear.
4.  Back in folder view, select any message.

Result:  Message body doesn't load.  Must focus folder pane or select another
folder and return, then selecting message will load properly.

Note:  This problem doesn't happen if you've done a search which matches items
in the view.

Comment 1

[laurel]

Was OK with yesterday's build, regressed in today's build.

Comment 2

[laurel]

*** Bug 123718 has been marked as a duplicate of this bug. ***

Comment 3

[laurel]

*** Bug 124934 has been marked as a duplicate of this bug. ***

Comment 4

[Navin Gupta]

Attachment: proposed fix

The fix is to make sure that whenever we are calling Save..Selection() we call
restoreSelection() because we suppress selection events in Save..Selection()
and
unsupress them in restoreSelection(). And to make this work
m_saveAndRestoreSelectionCount should be in sync. Here since we don't have any
hdrs in the  view we don't need to do all this SaveSelection and
RestoreSelection(). I have checked other instances of SaveSelection() and made
sure that we don't return early without RestoreSelection().

This bug was caused indirectly by seth's fix to bug 116174.

Comment 5

[Navin Gupta]

I mean if you don't call restoreSelection() m_saveAndRestoreCount will no
longer be in sync. 

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 69707 [details] [diff] [review]
proposed fix

sr=sspitzer

thanks for fixing my mistake.

Comment 7

[Navin Gupta]

fixed

Comment 8

[laurel]

OK using feb18 commercial trunk build: win98, mac OS 10.1, linux rh6.2