Closed Bug 1230192 Opened 4 years ago Closed 4 years ago

Loop's desktop unit tests are doing lots of unnecessary console.log of dispatcher actions

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Points:
1

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

Loop's desktop unit tests are doing lots of unnecessary console.log of dispatcher actions.
2.89 KB, patch
dcritchley
: review+
Details | Diff | Splinter Review 
Running the coverage tests the console spam is getting annoying - there's various places that we've accidentally enabled loop.debug.dispatcher.

We should fix that to make it easier to see real warnings/errors.
Comment on attachment 8695363 [details] [diff] [review]
Loop's desktop unit tests are doing lots of unnecessary console.log of dispatcher actions.

Review of attachment 8695363 [details] [diff] [review]:
-----------------------------------------------------------------

Looks Good
Attachment #8695363 - Flags: review?(dcritchley) → review+
https://hg.mozilla.org/mozilla-central/rev/f682b6e62684
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.