1230200 - test_settings_battery_power_save_mode.py : Exception: Element 'never' could not be found in select wrapper

Status: RESOLVED DUPLICATE of bug 1237399

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Max Ivanov[:MaxIvanov]]

Description: Test case fails with "raise Exception("Element '%s' could not be found in select wrapper" % match_string)"

Steps:
1. Update a flame device to 20151203030224
2. Run this test case http://lxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_battery_power_save_mode.py

Actual result:
"raise Exception("Element '%s' could not be found in select wrapper" % match_string)"

Expected result:
Test completes successfully.

Repro Rate: Reproduced via Jenkins adhoc (0/5 passing)
http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc.bitbar/361/HTML_Report/

Comment 1

[Martijn Wargers (dead)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/33503

No idea why the github plugin didn't attach the pull request to the bug this time.

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8695389 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/33503

straightforward fix.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8695389 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/33503

Based on our best practices[1], using a hard coded string makes us vulnerable to other string change and makes us not local agnostic. I'd use a data-l10n-id to perform the selection.

[1] https://wiki.mozilla.org/B2G/QA/Automation/Style_Guide/Python_Script_Style#Making_Tests_Locale_Independent

Comment 4

[Martijn Wargers (dead)]

Well, this is mainly about fixing the test. I thought the locale agnostic stuff was put on hold.

Comment 5

[Johan Lorenzo [:jlorenzo]]

You're right, the local agnostic is not a valid argument. Nonetheless, making a stronger patch still seems valid, it'll save time if they decided to change the string again, right?

Comment 6

[Martijn Wargers (dead)]

Well, we're switching over to Gij/Marionettejs, so presumably, we would have switched this test over by then.