Closed Bug 1230246 Opened 9 years ago Closed 5 years ago

Breakpoint does not remain on refresh within iframes, only on top level documents

Categories

(DevTools :: Debugger, defect, P3)

42 Branch
x86_64
Windows 10
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: gregwhitworth, Assigned: bhackett1024)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [debugger-mvp])

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2486.0 Safari/537.36 Edge/13.11073

Steps to reproduce:

Went to this site: http://www.thedamageisdone.net/?expref=next-blog
Opened dev tools
Switched to debugger
Inspected the "Followers Box" so that the scripts for the document will show up (it is an iframe)
Under blogger.com -> followers.g I set a breakpoint on line 71
Hit refresh



Actual results:

Breakpoint no longer remains, nor is hit on line 71 of the script


Expected results:

The breakpoint should be hit and allow for debugging
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Component: Untriaged → Developer Tools: Debugger
(Note the rpctoken query parameter)
Product: Firefox → DevTools

Honza, would you mind investigating?

Flags: needinfo?(odvarko)

Here are my STRs & analysis:

Part I.

  1. Open DevTools Toolbox and select the Debugger panel
  2. Load http://www.thedamageisdone.net/?expref=next-blog
  3. Select an iframe (using the button int the Toolbar, right side): followers.g
  4. Select www.bloger.com/followers.g file in the Sources panel
  5. Create BP at the first line in nextPage function (107 atm)
  6. Click next page (it's localized link) in the iframe
  7. BP hits, resume
  8. The iframe has been reloaded and:
  • The iframe picked in step #3 is no longer selected. The context is the page itself again.
  • The www.bloger.com/followers.g file is no longer selected in Source panel (I think it's actually not available there anymore, but should be)
  • The www.bloger.com/followers.g source tab is closed

Part II.

  1. Select www.bloger.com/followers.g file in the Sources panel again
  • You can notice that it has different source (but the same URL in the Sources panel?, does Source panel hides the query params? this seems to be wrong)
  • The BP from step #4 is gone, obviously (different URL with different URL params).
  • There is no nextPage function, but there is prevPage function
  1. Create BP at the first line in prevPage function (106 atm)
  2. Click prev page (it's localized link) in the iframe
  3. BP hits, resume
  • The source stays, BP stays, but doesn't work anymore
  • Check out the Sources view, the number of followers.g scripts grows every time you click, they have different URL -> thus BP don't work. Now the URL params are properly displayed.

  1. It looks like a problem with loosing the current frame => Not debugger related.
  2. There is the confusing thing with hiding URL params. The server returns different source & URL params every time and the Sources view seems to be confused => Debugger related.

@Jason, can you see the same results? Could this belong to dbg-sources meta?

Honza

Flags: needinfo?(odvarko) → needinfo?(jlaster)
Blocks: dbg-sources
Flags: needinfo?(jlaster)
Priority: -- → P3
Blocks: dbg-70
Whiteboard: [debugger-mvp]
Whiteboard: [debugger-mvp] → [debugger-reserve]
Blocks: dbg-71
No longer blocks: dbg-70
Whiteboard: [debugger-reserve] → [debugger-mvp]

Brian, would you be able to look into this?

Flags: needinfo?(bhackett1024)
Assignee: nobody → bhackett1024

(In reply to Jason Laster [:jlast] from comment #5)

Brian, would you be able to look into this?

I don't understand what change in behavior is desired from comment 4. When navigating backward and forward in the followers pane the client will show a bunch of followers.g sources, but they have different URL parameters (and the client shows the different URL parameters when there are more than one of them) so they are different sources and need breakpoints to be set differently. When going backward and forward several times a bunch of old followers.g sources will pile up, but those sources correspond to scripts that exist in the server (they won't be GC'ed as long as the devtools are attached) and the client is doing a good job of differentiating them AFAICT.

Flags: needinfo?(bhackett1024)
Flags: needinfo?(odvarko)

Thanks Brian for looking into this! The explanation make sense and I am closing this report.

@gwhit: feel free to reopen or file new one if you feel like there is still a bug

Thanks,
Honza

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(odvarko)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.