Closed
Bug 1230408
Opened 10 years ago
Closed 10 years ago
Assertion failure: "Any line break inside ruby box should have been suppressed" with :first-letter
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: jruderman, Assigned: xidorn)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Any line break inside ruby box should have been suppressed), at layout/generic/nsRubyBaseContainerFrame.cpp:663
|
Reporter | |
Comment 1•10 years ago
|
||
Flags: needinfo?(quanxunzhen)
|
Assignee | |
Comment 2•10 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28101/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28101/
Attachment #8698731 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•10 years ago
|
Flags: needinfo?(quanxunzhen)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → quanxunzhen
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8698731 [details]
MozReview Request: Bug 1230408 - Move suppress line break check out from control of SkipParentDisplayBasedStyleFixup.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28101/diff/1-2/
|
|
Assignee | |
Updated•10 years ago
|
status-firefox42:
--- → affected
status-firefox43:
--- → affected
status-firefox44:
--- → affected
status-firefox46:
--- → affected
status-firefox-esr38:
--- → affected
status-firefox-esr45:
--- → affected
Comment on attachment 8698731 [details]
MozReview Request: Bug 1230408 - Move suppress line break check out from control of SkipParentDisplayBasedStyleFixup.
https://reviewboard.mozilla.org/r/28101/#review26477
::: layout/style/nsStyleContext.cpp:525
(Diff revision 2)
> - if (aContainerDisplay->mDisplay == NS_STYLE_DISPLAY_INLINE ||
> - aContainerDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY ||
> - aContainerDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY_BASE_CONTAINER) {
> + if (aParentDisplay->mDisplay == NS_STYLE_DISPLAY_INLINE ||
> + aParentDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY ||
> + aParentDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY_BASE_CONTAINER) {
Should this test also consider display:contents now?
Attachment #8698731 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
(In reply to David Baron [:dbaron] ⌚️UTC-8 from comment #4)
> Comment on attachment 8698731 [details]
> MozReview Request: Bug 1230408 - Move suppress line break check out from
> control of SkipParentDisplayBasedStyleFixup.
>
> https://reviewboard.mozilla.org/r/28101/#review26477
>
> ::: layout/style/nsStyleContext.cpp:525
> (Diff revision 2)
> > - if (aContainerDisplay->mDisplay == NS_STYLE_DISPLAY_INLINE ||
> > - aContainerDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY ||
> > - aContainerDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY_BASE_CONTAINER) {
> > + if (aParentDisplay->mDisplay == NS_STYLE_DISPLAY_INLINE ||
> > + aParentDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY ||
> > + aParentDisplay->mDisplay == NS_STYLE_DISPLAY_RUBY_BASE_CONTAINER) {
>
> Should this test also consider display:contents now?
Yeah, you're right. Thanks.
|
|
Assignee | |
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75a467904c9e86b2add855fa16dafbfcb2b70c4a
Bug 1230408 - Move suppress line break check out from control of SkipParentDisplayBasedStyleFixup. r=dbaron
|
||
Comment 7•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•