1230425 - Assertion failure: mFrame->Combines3DTransformWithAncestors() || IsTransformSeparator()

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: mFrame->Combines3DTransformWithAncestors() || IsTransformSeparator(), at layout/base/nsDisplayList.h:4006

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I suspect either Matt or Thinker would know about this.

Comment 3

[Thinker Li [:sinker]]

I already has a fix at another bug.  I would move the patch to here.

Comment 4

[Thinker Li [:sinker]]

Attachment: WIP.diff

Matt, |BuildDisplayListForStackingContext()| decides if to install a transform item according the value of |IsTransformed()|.  |Combines3DTransformWithAncestors()| also checks if the frame is transformed, but in a bit different way.  The difference makes them inconsistent.

My idea is to call |IsTransformed()| in |Combines3DTransformWithAncestors()| instead of doing test by itself.  How do you think?

Comment 5

[Matt Woodrow (:mattwoodrow)]

(In reply to Thinker Li [:sinker] from comment #4)
> Created attachment 8809251 [details] [diff] [review]
> WIP.diff
> 
> Matt, |BuildDisplayListForStackingContext()| decides if to install a
> transform item according the value of |IsTransformed()|. 
> |Combines3DTransformWithAncestors()| also checks if the frame is
> transformed, but in a bit different way.  The difference makes them
> inconsistent.
> 
> My idea is to call |IsTransformed()| in |Combines3DTransformWithAncestors()|
> instead of doing test by itself.  How do you think?

This sounds good, but it's different what's in the attached patch.

Comment 6

[Thinker Li [:sinker]]

Attachment: Fix the test of transform of Combines3DTransformWithAncestors

Comment 7

[Thinker Li [:sinker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5aa1042e912f1ec1fa8ad2c178ad0d01fe305d2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c62b9c32517
Fix the test of transform of Combines3DTransformWithAncestors. r=mattwoodrow

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0c62b9c32517