Open Bug 1230644 Opened 9 years ago Updated 2 years ago

Add tests that suddenly interesting / uninteresting tabs are added / removed to the closedTabs array after an async flush

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

People

(Reporter: mconley, Unassigned, Mentored)

Details

Tabs that don't pass the test in SessionStore._shouldSaveTabState shouldn't be saved in the closedTabs array for a window.

We have to remember, however, that tab state flushes are asynchronous, and after one of these flushes, a tab that didn't pass SessionStore._shouldSaveTabState suddenly will, or that a tab that at first passed SessionStore._shouldSaveTabState no longer does.

We have code to handle that in SessionStore, but no tests for those cases. We should add those tests for closed tabs. We added similar tests in bug 1226333 for the closed window case.

Happy to mentor this one.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.