1230672 - Add support for column layout on <fieldset>

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Comment 1

[Mats Palmgren (inactive)]

Attachment: wip

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 1 - Make '-moz-column-fill:auto' work also when 'overflow' isn't 'visible'.

As I was writing reftests for <fieldset> with column layout I found this
existing bug.  I'll fix it here since it's just a one-liner.

Comment 3

[Mats Palmgren (inactive)]

Attachment: part 2 - Add reftest with -moz-column-fill:auto and overflow:hidden.

Comment 4

[Mats Palmgren (inactive)]

Attachment: part 3 - Add support for multicol layout on <fieldset> elements.

Comment 5

[Mats Palmgren (inactive)]

Attachment: part 4 - Reftests for <fieldset> with multicol layout.

Comment 6

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=135a129fd954

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8696290 [details] [diff] [review]
part 1 - Make '-moz-column-fill:auto' work also when 'overflow' isn't 'visible'.

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8696292 [details] [diff] [review]
part 3 - Add support for multicol layout on <fieldset> elements.

r=me, though the code duplication with ConstructBlock is a bit unfortunate.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9526d5d49b4
https://hg.mozilla.org/integration/mozilla-inbound/rev/950b5292fc5c
https://hg.mozilla.org/integration/mozilla-inbound/rev/82bb82a9b038
https://hg.mozilla.org/integration/mozilla-inbound/rev/708e6a7b11e5

Comment 10

[Phil Ringnalda (:philor)]

Backed out just the part 2 reftest changes in https://hg.mozilla.org/integration/mozilla-inbound/rev/eec861bce6d4, because we like to set you up to fail by not running either OS X 10.10 or WinXP tests on try unless you beg for them, and 10.10 didn't like the reftest change, https://treeherder.mozilla.org/logviewer.html#?job_id=18587815&repo=mozilla-inbound

Your trychooser patch's hint is out of date, what you want in the current era to get all desktop reftests is "reftest[Ubuntu,10.6,10.10,Windows XP,Windows 7,Windows 8]".

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9526d5d49b4
https://hg.mozilla.org/mozilla-central/rev/82bb82a9b038
https://hg.mozilla.org/mozilla-central/rev/708e6a7b11e5

Comment 12

[Mats Palmgren (inactive)]

(In reply to Phil Ringnalda (:philor) from comment #10)
> Backed out just the part 2 reftest changes in

Thanks philor.

> we like to set you up to fail by not running either OS X 10.10 or WinXP
> tests on try unless you beg for them,

Yeah, I really wish our tools could be smarter here.  Like if the push
contains changes to a reftest, or changes code under layout/ or gfx/ then
"-p all" really means "-p every-single-platform-we-run-reftests-on".

> Your trychooser patch's hint is out of date, what you want in the current
> era to get all desktop reftests is "reftest[Ubuntu,10.6,10.10,Windows
> XP,Windows 7,Windows 8]".

What I usually want is all platforms we run reftests on, including
Android, B2G, e10s variations etc.  I don't have time keep track of
which platform/test-suite combinations we run because that changes
quite often, so I really wish there was new keyword for this,
or if Try itself could be smarter about "all" as I said above.

Comment 13

[Mats Palmgren (inactive)]

The reftest failures on OSX 10.10 are anti-aliasing differences.
Adding fuzzyness for victory here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=78dc347c00b0

Comment 14

[Phil Ringnalda (:philor)]

Crap, I forgot about bug 1231995, until that's fixed you aren't actually going to get 10.10 reftest on try, just use m-i as your tryserver.

Comment 15

[Mats Palmgren (inactive)]

Thanks, I was a little puzzled why I didn't get any 10.10 runs there...
I retriggered a few manually, maybe that works.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fa1b85831b7

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Part 2 backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f3131740bb5d because the reftest.list syntax is apparently wrong:

https://treeherder.mozilla.org/logviewer.html#?job_id=18613469&repo=mozilla-inbound

Comment 18

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8af23e77ba02

Comment 19

[Mats Palmgren (inactive)]

Looks green on 10.10 now.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8af23e77ba02